daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-11182 test: Increase timeout for pool/create_all_hw.py (#9815)

Open knard38 opened this issue 3 years ago • 2 comments

Description

Increase the timeout of functional test pool/create_all_hw.py. Clean cherry pick of PR https://github.com/daos-stack/daos/pull/9815

knard38 avatar Aug 04 '22 05:08 knard38

Bug-tracker data: Ticket title is 'pool/create_all_hw.py:PoolCreateAllHwTests.test_one_pool - timeout during tearDown' Status is 'Awaiting backport' Labels: 'ci_impact,daily_test,triaged' Job should run at elevated priority (1) https://daosio.atlassian.net/browse/DAOS-11182

github-actions[bot] avatar Aug 04 '22 05:08 github-actions[bot]

@knard-intel the modified test was not executed by this pr. Because the src/tests/ftest/pool/create_all_hw.py test methods are tagged with daily_regression they are not run by the default tags and you need to add the following pragma to your commit message:

Test-tag: pool_create_all_one_hw, pool_create_all_recycle_hw, pool_create_all_two_hw

phender avatar Aug 11 '22 20:08 phender

-1 until the PR runs the modified tests (see earlier comment)

Did not pay attention during the cherry pick that the commit pragmas where removed when it was landed onto master. Thanks to have seen that, I am going to merge with the tip of the release/2.2 branch and update the pragma accordingly.

knard38 avatar Aug 19 '22 05:08 knard38

@daos

-1 until the PR runs the modified tests (see earlier comment)

FYI, modified tests have been run 20 times without errors :) More details could be found at https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-9896/6/pipeline

knard38 avatar Aug 22 '22 06:08 knard38

@daos-stack/daos-gatekeeper could tell me if something is missing to merge this PR ? If not, could you land it please ?

knard38 avatar Aug 31 '22 06:08 knard38

@daos-stack/daos-gatekeeper could you tell me if something is missing for landing this PR ?

knard38 avatar Sep 05 '22 06:09 knard38

@daos-stack/daos-gatekeeper could you tell me if something is missing for landing this PR ?

  1. There is still a -1 review by @phender. He needs to remove that if his requested changes have been addressed.
  2. It appears that a number of standard pr tests have not run. If this was intentional, please indicate that this is the case and request a forced landing.

mjmac avatar Sep 06 '22 13:09 mjmac

@daos-stack/daos-gatekeeper could you tell me if something is missing for landing this PR ?

  1. There is still a -1 review by @phender. He needs to remove that if his requested changes have been addressed.
  2. It appears that a number of standard pr tests have not run. If this was intentional, please indicate that this is the case and request a forced landing.

This PR only change the timeouts of the test pool_create_all running on the hw large cluster: This is why I only run the associated tests. I also add a tag to run theses tests 20 times to increase the confidence in the timeout used.

@phender please could you tell me if there is some changes which have not been addressed ?

knard38 avatar Sep 06 '22 13:09 knard38

@phender please could you tell me if your -1 is still needed as the target test has been run 20 times with success.

knard38 avatar Sep 08 '22 02:09 knard38