daos-stack
DAOS-10885: dmg pool create --size=percentage should allow --ranks
Description
This PR mainly add the support of the --ranks option with the pool create --size=<percentage> command.
As a side effect, it also better handle system with non homogeneous hardware configuration: servers with NVMe and other without.
Some external files where also changed to fix some pylint warning preventing the PR to be validated by the CI.
Validation
GoLang unit tests where adapted and completed.
One functional tests has been added to test this new functionality.
Bug-tracker data: Unable to load ticket data for 'DAOS-10885:' https://daosio.atlassian.net/browse/DAOS-10885:
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-9871/24/display/redirect
Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-9871/24/display/redirect
Test stage Functional Hardware Small completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-9871/24/display/redirect
Test stage Functional Hardware Small completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-9871/25/display/redirect
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-9871/25/display/redirect
Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-9871/26/display/redirect
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-9871/26/display/redirect
Test stage Functional Hardware Small completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-9871/26/display/redirect
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-9871/27/display/redirect
Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-9871/27/display/redirect
Test stage Functional Hardware Small completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-9871/27/display/redirect
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-9871/28/execution/node/1043/log
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-9871/29/execution/node/1037/log
Restart Ci test with deactivating functional test test_object_query. More details could be found at https://daosio.atlassian.net/browse/DAOS-11431
Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-9871/38/execution/node/1180/log
Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-9871/39/execution/node/310/log
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-9871/40/execution/node/1008/log
From what I understand, the Error from the CI is a timeout not related to this PR.
Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-9871/41/execution/node/145/log
LGTM. If you force push it makes it harder for reviewers to see incremental changes since their last review, please try to avoid it where possible, thanks.
My apologies for that, I forgot to commit some small code formatting cleanup and I wanted to avoid extra commits. I will avoid that next time.
Going to relaunch the CI as the functional test with the tag test_object_query has been fixed https://daosio.atlassian.net/browse/DAOS-11431
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-9871/44/execution/node/1091/log
Latest CI run is OK as only one test is failing on a known timeout issue:
- failing test:
ftest/daos_test/rebuild.py - Related JIRA ticket: https://daosio.atlassian.net/browse/DAOS-11178
@daos-stack/daos-gatekeeper could you tell me if something is missing for landing this PR ? If yes, could you tell me what should be updated.