DAOS-17095 client: disable flock as default in dfuse (#15952)

[shimizukko]

dfuse requires argument "--enable-local-flock" to enable the support of node-wise flock. Otherwise, flock is not supported as default since DAOS does not support a distributed flock.

Skip-unit-tests: true Skip-fault-injection-test: true Skip-func-hw-test-medium: false Test-tag: PosixSimul

Steps for the author:

• [ ] Commit message follows the guidelines.
• [ ] Appropriate Features or Test-tag pragmas were used.
• [ ] Appropriate Functional Test Stages were run.
• [ ] At least two positive code reviews including at least one code owner from each category referenced in the PR.
• [ ] Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

• [ ] Gatekeeper requested (daos-gatekeeper added as a reviewer).

[github-actions[bot]]

Ticket title is 'Need to return ENOTSUP for flock as default in dfuse' Status is 'Resolved' Labels: 'scrubbed_2.8' https://daosio.atlassian.net/browse/DAOS-17095

[shimizukko]

The unclean part is in src/client/dfuse/dfuse_main.c. The latest 2.6 has the following:

dfuse_info->di_threaded = true;
dfuse_info->di_caching  = true;
dfuse_info->di_wb_cache = true;
dfuse_info->di_eq_count = 1;
dfuse_info->di_dump_handles = false;
dfuse_info->di_read_handles = false;

The cherry-picked PR from March had the following:

dfuse_info->di_caching     = true;
dfuse_info->di_wb_cache    = true;
dfuse_info->di_eq_count    = 1;
dfuse_info->di_local_flock = false;

I kept everything from both and as a result, dfuse_info->di_local_flock = false; was added. (Also updated the copyright messages.)

[shimizukko]

This cherry-pick PR is for DAOS-18334; to allow dfuse/simul.py to work.

[mchaarawi]

This cherry-pick PR is for DAOS-18334; to allow dfuse/simul.py to work.

i do not get what the ticket has to do with this.. the ticket you mention is an issue with open mpi.. so flock has nothing to do with it. so if there is an issue with the test, you need to create a different ticket.

second, with simul, we used to skip some tests that do flock and other things bec they are not supported. so this should not be needed unless someone change the test.

[mchaarawi]

@phender correct me if im wrong, but for 2.6 we should just remove the mux for ompi, and not backport this entire PR?

[phender]

@phender correct me if im wrong, but for 2.6 we should just remove the mux for ompi, and not backport this entire PR?

Yes, https://daosio.atlassian.net/browse/DAOS-18334 was only asking for the src/tests/ftest/dfuse/simul.yaml change to be cherry-picked, not the whole https://github.com/daos-stack/daos/pull/15952/changes commit.