daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-18291 ddb: Remove DDB C dead code

Open knard38 opened this issue 2 months ago • 14 comments

Description

Remove ddb C legacy code related to command line parsing, mini-shell, etc.

Steps for the author:

  • [ ] Commit message follows the guidelines.
  • [ ] Appropriate Features or Test-tag pragmas were used.
  • [ ] Appropriate Functional Test Stages were run.
  • [ ] At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • [ ] Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • [ ] Gatekeeper requested (daos-gatekeeper added as a reviewer).

knard38 avatar Nov 28 '25 14:11 knard38

Ticket title is 'Remove DDB C dead code' Status is 'In Review' https://daosio.atlassian.net/browse/DAOS-18291

github-actions[bot] avatar Nov 28 '25 14:11 github-actions[bot]

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17198/1/testReport/

daosbuild3 avatar Nov 28 '25 18:11 daosbuild3

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17198/1/testReport/

daosbuild3 avatar Dec 01 '25 00:12 daosbuild3

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17198/2/testReport/

daosbuild3 avatar Dec 01 '25 09:12 daosbuild3

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17198/3/testReport/

daosbuild3 avatar Dec 01 '25 11:12 daosbuild3

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17198/3/testReport/

daosbuild3 avatar Dec 02 '25 00:12 daosbuild3

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17198/4/execution/node/1375/log

daosbuild3 avatar Dec 03 '25 03:12 daosbuild3

I am wondering why some ddb tests are removed? As my known, ddb_tests is still useful.

Not sure to understand your remarks. ddb_tests has not been removed. However, I have removed all the tests related to ddb command line and shell parsing feature. However, I could have removed too many tests. I will double check this.

knard38 avatar Dec 03 '25 08:12 knard38

I am wondering why some ddb tests are removed? As my known, ddb_tests is still useful.

Not sure to understand your remarks. ddb_tests has not been removed. However, I have removed all the tests related to ddb command line and shell parsing feature. However, I could have removed too many tests. I will double check this.

I have double checked and only useless tests should have been removed.

knard38 avatar Dec 03 '25 08:12 knard38

It is fine for me if we can move ddb UI related tests from C part ddb_tests to GO part ddb tests.

Created the ticket https://daosio.atlassian.net/browse/DAOS-18304

knard38 avatar Dec 04 '25 08:12 knard38

Test stage Unit Test on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17198/8/display/redirect

daosbuild3 avatar Dec 04 '25 08:12 daosbuild3

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17198/9/testReport/

daosbuild3 avatar Dec 04 '25 17:12 daosbuild3

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17198/11/testReport/

daosbuild3 avatar Dec 15 '25 16:12 daosbuild3

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17198/11/testReport/

daosbuild3 avatar Dec 16 '25 01:12 daosbuild3