daos-stack
DAOS-16501 build: Support of mercury with ASan
Description
Instrument mercury with libasan according to build option SANITIZERS
Steps for the author:
- [x] Commit message follows the guidelines.
- [ ] Appropriate Features or Test-tag pragmas were used.
- [ ] Appropriate Functional Test Stages were run.
- [ ] At least two positive code reviews including at least one code owner from each category referenced in the PR.
- [ ] Testing is complete. If necessary, forced-landing label added and a reason added in a comment.
After all prior steps are complete:
- [ ] Gatekeeper requested (daos-gatekeeper added as a reviewer).
Ticket title is 'LRZ: m02r01s10dao coredump - invalid free' Status is 'Resolved' Labels: 'lrz' https://daosio.atlassian.net/browse/DAOS-16501
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16917/1/execution/node/1462/log
Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-16917/2/testReport/
Test stage NLT on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16917/3/display/redirect
Test stage Unit Test bdev with memcheck on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16917/3/display/redirect
Test stage Unit Test on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16917/3/display/redirect
Test stage Unit Test bdev on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16917/3/display/redirect
Test stage Unit Test with memcheck on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16917/3/display/redirect
@knard38 see new option I have added in https://github.com/mercury-hpc/mercury/commit/74dda4a6a161fceb3445d43ea4a3d71f3bd0cf79
@knard38 see new option I have added in mercury-hpc/mercury@74dda4a
I am going to update the PR accordingly
You need to add an entry to daos.spec changelog, bump the daos and mercury versions. See this:
Without updating the mercury version, this will never build in CI because there is already a mercury to use.
https://github.com/daos-stack/daos/blob/master/docs/dev/development.md#updating-a-3rd-party-component
- [x] Fix CI integration
@knard38 see new option I have added in mercury-hpc/mercury@74dda4a
- [x] Use official mercury patch 74dda4a
You need to add an entry to daos.spec changelog, bump the daos and mercury versions. See this: Without updating the mercury version, this will never build in CI because there is already a mercury to use. https://github.com/daos-stack/daos/blob/master/docs/dev/development.md#updating-a-3rd-party-component
- [x] Fix CI integration
Fixed with commit 5cb9bbeb6
@knard38 see new option I have added in mercury-hpc/mercury@74dda4a
- [x] Use official mercury patch 74dda4a
Fixed with commit 5cb9bbeb6
@soumagne this seems like a better option for the change logs
https://github.com/daos-stack/daos/pull/17063#pullrequestreview-3404941845
@soumagne this seems like a better option for the change logs
It seems that the integration of the changelog is not compatible as it with Mercury. I am going to investigate.
@soumagne this seems like a better option for the change logs #17063 (review)
It seems that the integration of the changelog is not compatible as it with Mercury. I am going to investigate.
don't worry about it for now, maybe it's best that you wait that I merge my PR first that updates mercury to 2.4.1 first and includes your patch, I have also added the changeling there. See https://github.com/daos-stack/daos/pull/16943
@soumagne this seems like a better option for the change logs #17063 (review)
It seems that the integration of the changelog is not compatible as it with Mercury. I am going to investigate.
don't worry about it for now, maybe it's best that you wait that I merge my PR first that updates mercury to 2.4.1 first and includes your patch, I have also added the changeling there. See #16943
I have fixed it: locally tested. Also takes the opportunity to improve the fpm error messages. I will wait after the merge of your PR.