daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-17550 object: refine dc_array_set_size processing

Open liuxuezhao opened this issue 9 months ago • 4 comments

  1. use memcmp rather than strncmp in merge_key strncmp can cause some keys be incorrectly ignored
  2. refine list dkey by providing more memory to save RPC round-trip.

Steps for the author:

  • [ ] Commit message follows the guidelines.
  • [ ] Appropriate Features or Test-tag pragmas were used.
  • [ ] Appropriate Functional Test Stages were run.
  • [ ] At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • [ ] Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • [ ] Gatekeeper requested (daos-gatekeeper added as a reviewer).

liuxuezhao avatar May 18 '25 07:05 liuxuezhao

Ticket title is 'truncating an EC file to 0 does not work on the first try' Status is 'In Review' Labels: 'scrubbed_2.8' Job should run at elevated priority (1) https://daosio.atlassian.net/browse/DAOS-17550

github-actions[bot] avatar May 18 '25 07:05 github-actions[bot]

i have not tested on aurora yet, but will do soon

mchaarawi avatar May 18 '25 19:05 mchaarawi

im going to revert my +1 because the performance of the patch on aurora increases by 5x.

i just tested the memcmp fix, and that works as expected. but the "improvement" in the array code made truncate worse my 5x: With 4:26.38 minutes Without 0:50.03 minutes

let's remove the other changes from the PR and just keep the memcmp fix please

could you please test again with the refreshed PR? the original code only list 5 dkeys every time it looks not very good, you may tune the number of "ENUM_DESC_NR_MAX" and the nr/buf_size in sub_anchors_prep() to see what is better on aurora. thanks

liuxuezhao avatar May 19 '25 03:05 liuxuezhao

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16404/2/execution/node/1372/log

daosbuild3 avatar May 27 '25 17:05 daosbuild3