daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-16702 rebuild: restart rebuild for a massive failure case

Open liuxuezhao opened this issue 1 year ago • 5 comments

In special massive failure case -

  1. some engines down and triggered rebuild.
  2. one engine participated the rebuild, not finished yet, it down again, the #failures exceeds pool RF and will not change pool map.
  3. That engine restarted by administrator.

In that case should recover the rebuild task on the engine, to simplify it now just abort and retry the global rebuild task. No such issue by the typical recover approach that restart the whole system including the PS leader.

Before requesting gatekeeper:

  • [ ] Two review approvals and any prior change requests have been resolved.
  • [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • [ ] Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • [ ] Commit messages follows the guidelines outlined here.
  • [ ] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • [ ] You are the appropriate gatekeeper to be landing the patch.
  • [ ] The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • [ ] Githooks were used. If not, request that user install them and check copyright dates.
  • [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • [ ] All builds have passed. Check non-required builds for any new compiler warnings.
  • [ ] Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • [ ] If applicable, the PR has addressed any potential version compatibility issues.
  • [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • [ ] Extra checks if forced landing is requested
    • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • [ ] No new NLT or valgrind warnings. Check the classic view.
    • [ ] Quick-build or Quick-functional is not used.
  • [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

liuxuezhao avatar Oct 18 '24 10:10 liuxuezhao

Ticket title is 'Rebuilding cannot be completed after restarting ranks in cases of massive failures.' Status is 'In Progress' https://daosio.atlassian.net/browse/DAOS-16702

github-actions[bot] avatar Oct 18 '24 10:10 github-actions[bot]

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15343/2/execution/node/1397/log

daosbuild1 avatar Oct 19 '24 00:10 daosbuild1

I run test locally, somehow rebuild finished but with 2007 errors, and retry forever.

at my side I tested DER_STALE will retry and finish. I'll check details with you offline

liuxuezhao avatar Oct 21 '24 08:10 liuxuezhao

I run test locally, somehow rebuild finished but with 2007 errors, and retry forever.

at my side I tested DER_STALE will retry and finish. I'll check details with you offline

See logs here:

https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15354/1/artifact/Functional%20on%20EL%208.8/control/dmg_pool_query_ranks.py/job.log/view/

dmg pool query timeout after restarting rank, but rebuild did not finish too.

wangshilong avatar Oct 21 '24 13:10 wangshilong

https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15354/1/artifact/Functional%20on%20EL%208.8/control/dmg_pool_query_ranks.py/job.log/view/

dmg pool query timeout after restarting rank, but rebuild did not finish too.

I ran several test on wolf wit similar steps and be able to reproduce a rebuild timeout issue. The problem is the ALIVE event got from CRT_EVS_GRPMOD rather than CRT_EVS_SWIM, so cannot ignore CRT_EVS_GRPMOD event. I changed handle_event a little bit @liw please check if it is good for you. @wangshilong please retest with the new version. thx

liuxuezhao avatar Oct 21 '24 17:10 liuxuezhao

pushed a new commit to resolve a race condition of rpt not stoped intime when restart new rebuild.

liuxuezhao avatar Oct 24 '24 09:10 liuxuezhao