daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-16469 dtx: properly handle DTX partial commit

Open Nasf-Fan opened this issue 1 year ago • 1 comments

When a DTX leader globally commit the DTX, it is possible that some DTX participant(s) cannot commit such DTX entry because of kinds of issues, such as network or space trouble. Under such case, the DTX leader needs to keep the active DTX entry persistently for further commit/resync. But it does not means related modification attched to such DTX entry on the leader target cannot be committed, instead, we can commit related modification with only keeping the DTX header. That is enough for the DTX leader to do further DTX commit/resync to handle related former failed DTX participant(s).

The benefit is that VOS aggregation on the leader target will not be affected by remote DTX commit failure.

The patch also reduces DTX related warning to avoid log flood.

Allow-unstable-test: true

Before requesting gatekeeper:

  • [ ] Two review approvals and any prior change requests have been resolved.
  • [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • [ ] Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • [ ] Commit messages follows the guidelines outlined here.
  • [ ] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • [ ] You are the appropriate gatekeeper to be landing the patch.
  • [ ] The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • [ ] Githooks were used. If not, request that user install them and check copyright dates.
  • [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • [ ] All builds have passed. Check non-required builds for any new compiler warnings.
  • [ ] Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • [ ] If applicable, the PR has addressed any potential version compatibility issues.
  • [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • [ ] Extra checks if forced landing is requested
    • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • [ ] No new NLT or valgrind warnings. Check the classic view.
    • [ ] Quick-build or Quick-functional is not used.
  • [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Nasf-Fan avatar Oct 17 '24 14:10 Nasf-Fan

Ticket title is 'IOR Easy performance low with EC_16P2GX' Status is 'In Progress' Labels: 'daos_ecb_scale,pre_acceptance_issues' Job should run at elevated priority (1) https://daosio.atlassian.net/browse/DAOS-16469

github-actions[bot] avatar Oct 17 '24 14:10 github-actions[bot]

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15335/7/execution/node/1565/log

daosbuild1 avatar Oct 24 '24 08:10 daosbuild1

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15335/12/testReport/

daosbuild1 avatar Nov 08 '24 09:11 daosbuild1

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15335/13/testReport/

daosbuild1 avatar Nov 08 '24 16:11 daosbuild1

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15335/14/testReport/

daosbuild1 avatar Nov 09 '24 02:11 daosbuild1

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15335/15/testReport/

daosbuild1 avatar Nov 09 '24 14:11 daosbuild1

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15335/16/testReport/

daosbuild1 avatar Nov 09 '24 15:11 daosbuild1

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15335/17/testReport/

daosbuild1 avatar Nov 09 '24 16:11 daosbuild1

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15335/18/testReport/

daosbuild1 avatar Nov 09 '24 18:11 daosbuild1

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15335/19/testReport/

daosbuild1 avatar Nov 10 '24 04:11 daosbuild1

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15335/19/execution/node/1482/log

daosbuild1 avatar Nov 11 '24 10:11 daosbuild1

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15335/20/testReport/

daosbuild1 avatar Nov 12 '24 16:11 daosbuild1

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15335/20/execution/node/1462/log

daosbuild1 avatar Nov 13 '24 03:11 daosbuild1

Ping reviewers, thanks!

Nasf-Fan avatar Nov 18 '24 05:11 Nasf-Fan

Ping @daos-stack/daos-gatekeeper , thanks!

Nasf-Fan avatar Dec 02 '24 15:12 Nasf-Fan

Ping @daos-stack/daos-gatekeeper , thanks!

Ideally should have an approval from @daos-stack/vos-owners before merging, or I will defer to @gnailzenh on DTX PRs since I am not familiar enough.

daltonbohning avatar Dec 12 '24 20:12 daltonbohning

Ping @gnailzenh

Nasf-Fan avatar Dec 19 '24 16:12 Nasf-Fan