daos DAOS-14698 crtl: Create container with attributes

Description

Add new option attr to daos cont create allowing to define container user attributes.

Before requesting gatekeeper:

[ ] Two review approvals and any prior change requests have been resolved.
[ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
[ ] Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
[ ] Commit messages follows the guidelines outlined here.
[ ] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

[ ] You are the appropriate gatekeeper to be landing the patch.
[ ] The PR has 2 reviews by people familiar with the code, including appropriate owners.
[ ] Githooks were used. If not, request that user install them and check copyright dates.
[ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
[ ] All builds have passed. Check non-required builds for any new compiler warnings.
[ ] Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
[ ] If applicable, the PR has addressed any potential version compatibility issues.
[ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
[ ] Extra checks if forced landing is requested
- [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
- [ ] No new NLT or valgrind warnings. Check the classic view.
- [ ] Quick-build or Quick-functional is not used.
[ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Oct 11 '24 21:10 knard38

Ticket title is 'Creating daos container with dfuse cache settings.' Status is 'In Review' Labels: 'triaged,usability' Errors are Unknown component https://daosio.atlassian.net/browse/DAOS-14698

Oct 11 '24 21:10 github-actions[bot]

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15300/4/testReport/

Oct 18 '24 16:10 daosbuild1

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15300/6/testReport/

Oct 21 '24 10:10 daosbuild1

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15300/7/testReport/

Oct 21 '24 12:10 daosbuild1

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15300/7/execution/node/1217/log

Oct 21 '24 22:10 daosbuild1

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15300/9/execution/node/373/log

Oct 22 '24 12:10 daosbuild1

Last two forced push was just for fixing minor issues introduced with the commit https://github.com/daos-stack/daos/commit/819b856455ea7ad9a0fe3e3bb0d851aaa5b10afc

Oct 22 '24 12:10 knard38

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15300/15/execution/node/1120/log

Oct 25 '24 07:10 daosbuild1

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15300/16/execution/node/491/log

Oct 25 '24 13:10 daosbuild1

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15300/21/execution/node/1210/log

Nov 01 '24 04:11 daosbuild1

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15300/24/execution/node/1211/log

Nov 05 '24 00:11 daosbuild1

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15300/25/testReport/

Nov 05 '24 22:11 daosbuild1

It would be good to add some attributes to the new container in , this would check the unwinding code is correct in case of failure partway through.

[x] Add some attributes to the test_alloc_fail_cont_create function in NLT.

Nov 15 '24 13:11 knard38

It would be good to add some attributes to the new container in , this would check the unwinding code is correct in case of failure partway through.

[x] Add some attributes to the test_alloc_fail_cont_create function in NLT.

Fixed with commit e3f510d

Nov 15 '24 14:11 knard38

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15300/30/execution/node/365/log

Nov 15 '24 16:11 daosbuild1

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15300/30/execution/node/371/log

Nov 15 '24 16:11 daosbuild1

Hello reviewers, Hopefully, I should have integrated all your comments :-)

@mchaarawi could you have a look at the C code to check if the modifications are OK for you.
@mjmac and/or @kjacque could you have a look at the GO code to check if the modifications are OK for you.
@daltonbohning and/or @phender could you have a look at the functional test parts to check if the modifications are OK for you.

Thanks in advance, Cedric.

Nov 18 '24 20:11 knard38

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15300/33/execution/node/1186/log

Nov 22 '24 05:11 daosbuild1

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15300/34/execution/node/1210/log

Nov 22 '24 19:11 daosbuild1

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15300/35/execution/node/1210/log

Nov 23 '24 10:11 daosbuild1

The failing test pool/query_attribute.py is a regression recently introduced on master. I am going to open JIRA ticket to solved

Nov 25 '24 13:11 knard38

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15300/36/testReport/

Nov 26 '24 09:11 daosbuild1

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15300/37/testReport/

Nov 26 '24 16:11 daosbuild1

Increase maximal log size of NLT size as last test failed with the following message:

Max log size exceeded, 1.7GiB > 1.7GiB

Nov 28 '24 17:11 knard38

Force push was just for updating the commit message to skip known functional test failure.

Nov 28 '24 17:11 knard38

Force push again as the skip-test macros is not working as expected.

Nov 29 '24 07:11 knard38

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15300/40/execution/node/1210/log

Nov 29 '24 21:11 daosbuild1

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15300/45/execution/node/1211/log

Dec 06 '24 21:12 daosbuild1

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15300/48/execution/node/1210/log

Dec 10 '24 07:12 daosbuild1

Hello reviewers,

Hopefully, I should have integrated all your comments :-)

@mchaarawi could you have a look at the C code and NLT test to check if the modifications are OK for you.
@mjmac and/or @kjacque could you have a look at the GO code to check if the modifications are OK for you.
@daltonbohning and/or @phender could you have a look at the functional test parts to check if the modifications are OK for you.

The two errors of the functional tests are known issues:

dfuse/mu_perms.py: related to ticket DAOS-16695
pool/query_attribute.py: related to ticket DAOS-16829

Thanks in advance, Cedric.

Dec 11 '24 07:12 knard38