DAOS-16488 chk: take sd_lock before accessing VOS sys_db - b26

[Nasf-Fan]

The VOS sys_db may have multuiple users, such as SMD and CHK. It is caller's duty to take lock against the VOS sys_db before accessing it to handle concurrent operations from multiple XS.

Features: CatRecovCoreTest Allow-unstable-test: true

Before requesting gatekeeper:

• [ ] Two review approvals and any prior change requests have been resolved.
• [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
• [ ] Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
• [ ] Commit messages follows the guidelines outlined here.
• [ ] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

• [ ] You are the appropriate gatekeeper to be landing the patch.
• [ ] The PR has 2 reviews by people familiar with the code, including appropriate owners.
• [ ] Githooks were used. If not, request that user install them and check copyright dates.
• [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
• [ ] All builds have passed. Check non-required builds for any new compiler warnings.
• [ ] Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
• [ ] If applicable, the PR has addressed any potential version compatibility issues.
• [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
• [ ] Extra checks if forced landing is requested
  • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
  • [ ] No new NLT or valgrind warnings. Check the classic view.
  • [ ] Quick-build or Quick-functional is not used.
• [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

[github-actions[bot]]

Ticket title is 'lru_ref_release_internal() Assertion 'd_list_empty(&llink->ll_qlink)' failed' Status is 'Awaiting backport' Labels: 'ci_2.6_daily,ci_master_daily,daily_test,verbs_provider' Job should run at elevated priority (1) https://daosio.atlassian.net/browse/DAOS-16488

[daltonbohning]

We need to run the test being fixed

Features: CatRecovCoreTest

[daosbuild1]

Test stage Unit Test with memcheck on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15269/4/testReport/

[daosbuild1]

Test stage Unit Test bdev with memcheck on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15269/4/testReport/

[Nasf-Fan]

NLT warning, not related with the patch.

[Nasf-Fan]

Ping reviewer, thanks!

[daltonbohning]

We need to run the test being fixed

Features: CatRecovCoreTest

This test still needs to be ran. New commits unfortunately do not carry forward previous commit pragmas so have to be specified each time

[daosbuild1]

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15269/12/testReport/

[daltonbohning]

IMO we really should not have merged this without it running the test it is supposed to fix. The same was done with the master PR, and that PR introduced more failures in the same area it was supposed to fix.