daos-stack
DAOS-16621 build: Fix Go versions in rpm/deb packaging (#15174)
- Set Go minimum version to 1.21 in rpm and debian packaging spec files.
- Update scons Go version check to use version in go.mod.
- Add a reminder in go.mod file so we remember the packaging files when bumping the minimum Go version in the future.
- Update Ubuntu 22.04 Dockerfile to get an appropriate version of Go.
Required-githooks: true
Before requesting gatekeeper:
- [x] Two review approvals and any prior change requests have been resolved.
- [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
- [x]
Features:(orTest-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR. - [x] Commit messages follows the guidelines outlined here.
- [x] Any tests skipped by the ticket being addressed have been run and passed in the PR.
Gatekeeper:
- [ ] You are the appropriate gatekeeper to be landing the patch.
- [ ] The PR has 2 reviews by people familiar with the code, including appropriate owners.
- [ ] Githooks were used. If not, request that user install them and check copyright dates.
- [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
- [ ] All builds have passed. Check non-required builds for any new compiler warnings.
- [ ] Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
- [ ] If applicable, the PR has addressed any potential version compatibility issues.
- [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
- [ ] Extra checks if forced landing is requested
- [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
- [ ] No new NLT or valgrind warnings. Check the classic view.
- [ ] Quick-build or Quick-functional is not used.
- [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.
No need for Features tags, as this affects only builds.
Both conflicts in the cherry-pick were in the changelog section of the RPM specfile and the Debian changelog.
Ticket title is 'Fix Go version checks in scons and packaging specfiles' Status is 'Awaiting backport' Labels: 'scrubbed_2.8' Job should run at elevated priority (1) https://daosio.atlassian.net/browse/DAOS-16621
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
NLT failures appear to be unrelated to this PR. I've added the Allow-unstable pragma to allow us to bypass the failures.
Dug deeper into the NLT instability and created a ticket: https://daosio.atlassian.net/browse/DAOS-16716
This affects any 2.6 PR, not just this one.
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15255/7/execution/node/1430/log
FYI release/2.6 currently closed until we cut a test build for Aurora acceptance
Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15255/9/execution/node/352/log
Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15255/9/execution/node/357/log
Ubuntu-related build failures also need #15563 and #15607, which in turn rely on this PR. I think let's ignore the Ubuntu failures on this PR, assuming they are not directly related. Then #15563 and #15607 should fix them.
Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15255/11/testReport/