daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-16469 dtx: optimize DTX CoS cache - b26

Open Nasf-Fan opened this issue 1 year ago • 14 comments

If there are a lot of committable DTX entries in DTX CoS cache, then it may be inefficient to locate the DTX entry in CoS cache with given oid + dkey_hash, that may happen under the case of that DTX batched commit is blocked (such as because of network trouble) as to trigger DTX refresh (for DTX cleanup) on other related engines. If that happened, it will increase the system load on such engine and slow down DTX commit further more. The patch reduces unnecessary search operation inside CoS cache.

Other changes:

  1. Metrics (io/dtx/async_cmt_lat/tgt_id) for DTX asynchronously commit latency (with unit ms).

  2. Fix a bug in sched_ult2xs() with multiple numa sockets for DSS_XS_OFFLOAD case.

  3. Delay commit (or abort) collective DTX on the leader target to handle resent race.

  4. Avoid blocking dtx_req_wait() if chore failed to send out some DTX RPC.

  5. Some cleanup for error handling.

Before requesting gatekeeper:

  • [ ] Two review approvals and any prior change requests have been resolved.
  • [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • [ ] Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • [ ] Commit messages follows the guidelines outlined here.
  • [ ] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • [ ] You are the appropriate gatekeeper to be landing the patch.
  • [ ] The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • [ ] Githooks were used. If not, request that user install them and check copyright dates.
  • [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • [ ] All builds have passed. Check non-required builds for any new compiler warnings.
  • [ ] Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • [ ] If applicable, the PR has addressed any potential version compatibility issues.
  • [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • [ ] Extra checks if forced landing is requested
    • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • [ ] No new NLT or valgrind warnings. Check the classic view.
    • [ ] Quick-build or Quick-functional is not used.
  • [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Nasf-Fan avatar Sep 06 '24 10:09 Nasf-Fan

Ticket title is 'IOR Easy performance low with EC_16P2GX' Status is 'In Progress' Labels: 'daos_ecb_scale,pre_acceptance_issues' https://daosio.atlassian.net/browse/DAOS-16469

github-actions[bot] avatar Sep 06 '24 10:09 github-actions[bot]

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15085/2/testReport/

daosbuild1 avatar Sep 06 '24 14:09 daosbuild1

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15085/3/testReport/

daosbuild1 avatar Sep 06 '24 15:09 daosbuild1

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15085/4/testReport/

daosbuild1 avatar Sep 06 '24 21:09 daosbuild1

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15085/5/execution/node/1424/log

daosbuild1 avatar Sep 08 '24 05:09 daosbuild1

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15085/5/execution/node/1470/log

daosbuild1 avatar Sep 08 '24 06:09 daosbuild1

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15085/5/execution/node/1616/log

daosbuild1 avatar Sep 08 '24 09:09 daosbuild1

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15085/7/execution/node/1509/log

daosbuild1 avatar Sep 09 '24 10:09 daosbuild1

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15085/7/execution/node/1493/log

daosbuild1 avatar Sep 09 '24 12:09 daosbuild1

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15085/8/execution/node/1446/log

daosbuild1 avatar Sep 10 '24 13:09 daosbuild1

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15085/10/testReport/

daosbuild1 avatar Sep 11 '24 02:09 daosbuild1

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15085/11/execution/node/1551/log

daosbuild1 avatar Sep 11 '24 11:09 daosbuild1

Ping reviewers, thanks!

Nasf-Fan avatar Oct 20 '24 17:10 Nasf-Fan

Ping reviewers, thanks!

Nasf-Fan avatar Oct 23 '24 01:10 Nasf-Fan