daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-16386 utils: Add DDB Feature and RM_POOL Support

Open wangshilong opened this issue 1 year ago • 4 comments

This PR enhances the DDB functionality for CR purposes with the following updates:

  1. Pool Behavior Control:

Administrators can now control certain vos pool behaviors, such as skipping vos pool loading or setting a vos pool to immutable mode.

  1. Manual Pool Shard Removal:

A new command ddb rm_pool <vos_pool> has been introduced, allowing administrators to manually remove pool shards.

  1. SPDK Environment Initialization Bug Fix:

Fixed an issue where spdk_env_init() would fail during reinitialization.

These updates aim to improve system flexibility and stability, providing administrators with more robust management capabilities.

Required-githooks: true Signed-off-by: Wang Shilong [email protected]

Required-githooks: true

Before requesting gatekeeper:

  • [ ] Two review approvals and any prior change requests have been resolved.
  • [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • [ ] Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • [ ] Commit messages follows the guidelines outlined here.
  • [ ] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • [ ] You are the appropriate gatekeeper to be landing the patch.
  • [ ] The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • [ ] Githooks were used. If not, request that user install them and check copyright dates.
  • [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • [ ] All builds have passed. Check non-required builds for any new compiler warnings.
  • [ ] Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • [ ] If applicable, the PR has addressed any potential version compatibility issues.
  • [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • [ ] Extra checks if forced landing is requested
    • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • [ ] No new NLT or valgrind warnings. Check the classic view.
    • [ ] Quick-build or Quick-functional is not used.
  • [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

wangshilong avatar Sep 04 '24 09:09 wangshilong

Ticket title is 'Enhance DDB for CR purpose' Status is 'In Review' https://daosio.atlassian.net/browse/DAOS-16386

github-actions[bot] avatar Sep 04 '24 09:09 github-actions[bot]

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15062/1/testReport/

daosbuild1 avatar Sep 04 '24 10:09 daosbuild1

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15062/3/testReport/

daosbuild1 avatar Sep 26 '24 00:09 daosbuild1

LGTM, is there a reason we couldn't use go-flags for the go cli front-end and instead had to pull in "grumble" package?

I tried to follow @ryon-jensen , maybe he could help answer this.

wangshilong avatar Oct 08 '24 07:10 wangshilong

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15062/6/execution/node/360/log

daosbuild1 avatar Oct 28 '24 02:10 daosbuild1

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15062/6/execution/node/387/log

daosbuild1 avatar Oct 28 '24 02:10 daosbuild1

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15062/6/execution/node/273/log

daosbuild1 avatar Oct 28 '24 02:10 daosbuild1

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15062/6/execution/node/363/log

daosbuild1 avatar Oct 28 '24 02:10 daosbuild1

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15062/6/execution/node/326/log

daosbuild1 avatar Oct 28 '24 02:10 daosbuild1

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15062/6/execution/node/323/log

daosbuild1 avatar Oct 28 '24 02:10 daosbuild1

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15062/8/testReport/

daosbuild1 avatar Oct 30 '24 08:10 daosbuild1

Test stage Unit Test with memcheck on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15062/8/testReport/

daosbuild1 avatar Oct 30 '24 08:10 daosbuild1