daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-15992 client: set st_blksize in ostatx_cb() and add unit test

Open wiliamhuang opened this issue 1 year ago • 1 comments

Python buffered read/write relies on st_blksize as default buffer size. dfuse calls dfs_ostatx() which returns stat with zero st_blksize. Consequently, 4096 for st_blksize is returned to application.

Before requesting gatekeeper:

  • [ ] Two review approvals and any prior change requests have been resolved.
  • [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • [ ] Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • [ ] Commit messages follows the guidelines outlined here.
  • [ ] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • [ ] You are the appropriate gatekeeper to be landing the patch.
  • [ ] The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • [ ] Githooks were used. If not, request that user install them and check copyright dates.
  • [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • [ ] All builds have passed. Check non-required builds for any new compiler warnings.
  • [ ] Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • [ ] If applicable, the PR has addressed any potential version compatibility issues.
  • [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • [ ] Extra checks if forced landing is requested
    • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • [ ] No new NLT or valgrind warnings. Check the classic view.
    • [ ] Quick-build or Quick-functional is not used.
  • [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

wiliamhuang avatar Jun 28 '24 17:06 wiliamhuang

Ticket title is 'st_blksize in stat is not set inside ostatx_cb' Status is 'Awaiting backport' Labels: 'scrubbed_2.8' Job should run at elevated priority (1) https://daosio.atlassian.net/browse/DAOS-15992

github-actions[bot] avatar Jun 28 '24 17:06 github-actions[bot]

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14666/2/execution/node/1563/log

daosbuild1 avatar Jul 08 '24 01:07 daosbuild1

Test stage Functional Hardware Medium UCX Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14666/2/execution/node/1709/log

daosbuild1 avatar Jul 08 '24 03:07 daosbuild1

The failures in hardware tests in CI are not related to this PR. Existing tickets, https://daosio.atlassian.net/browse/DAOS-15608 https://daosio.atlassian.net/browse/DAOS-16168 https://daosio.atlassian.net/browse/DAOS-15243

wiliamhuang avatar Jul 08 '24 15:07 wiliamhuang

could you please rebase with latest 2.6 and push again? thanks

mchaarawi avatar Jul 31 '24 13:07 mchaarawi

could you please rebase with latest 2.6 and push again? thanks

Thank you! I just merged this PR with release/2.6.

wiliamhuang avatar Jul 31 '24 13:07 wiliamhuang

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14666/4/execution/node/1508/log

daosbuild1 avatar Aug 17 '24 06:08 daosbuild1

The only failure is an existing issue. https://daosio.atlassian.net/browse/DAOS-16315 dfuse/pil4dfs_fio.py:Pil4dfsFio.test_pil4dfs_vs_dfs - test timeout running fio

wiliamhuang avatar Aug 20 '24 23:08 wiliamhuang