DAOS-15851 ci: Follow CI_PR_REPOS if provided by Jenkins

[grom72]

Required for: https://github.com/daos-stack/go-build-toolchain/pull/25/commits/c8fde3edc5f3adee464db95228b67535f2d21031

Before requesting gatekeeper:

• [ ] Two review approvals and any prior change requests have been resolved.
• [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
• [ ] Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
• [ ] Commit messages follows the guidelines outlined here.
• [ ] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

• [ ] You are the appropriate gatekeeper to be landing the patch.
• [ ] The PR has 2 reviews by people familiar with the code, including appropriate owners.
• [ ] Githooks were used. If not, request that user install them and check copyright dates.
• [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
• [ ] All builds have passed. Check non-required builds for any new compiler warnings.
• [ ] Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
• [ ] If applicable, the PR has addressed any potential version compatibility issues.
• [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
• [ ] Extra checks if forced landing is requested
  • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
  • [ ] No new NLT or valgrind warnings. Check the classic view.
  • [ ] Quick-build or Quick-functional is not used.
• [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

[github-actions[bot]]

Errors are Unable to load ticket data https://daosio.atlassian.net/browse/DAOS-15851

[daosbuild1]

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14387/6/execution/node/340/log

[daosbuild1]

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14387/6/execution/node/339/log

[daosbuild1]

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14387/6/execution/node/368/log

[daosbuild1]

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14387/6/execution/node/352/log

[daosbuild1]

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14387/7/execution/node/343/log

[daosbuild1]

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14387/7/execution/node/349/log

[daosbuild1]

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14387/7/execution/node/371/log

[daosbuild1]

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14387/7/execution/node/346/log

[daosbuild1]

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14387/7/display/redirect

[daosbuild1]

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14387/7/display/redirect

[grom72]

@brianjmurrell please take a look at: https://build.hpdd.intel.com/job/daos-stack/job/daos/job/ci-daos-stack-go-build-toolchain-PR-25-master/31/parameters/ and confirm that the solution works as you expect.

[brianjmurrell]

@brianjmurrell please take a look at: build.hpdd.intel.com/job/daos-stack/job/daos/job/ci-daos-stack-go-build-toolchain-PR-25-master/31/parameters and confirm that the solution works as you expect.

Excellent work! It does work as expected, for the most part. As we can see in the EL8 RPM build log:

[2024-05-22T15:07:55.555Z] DEBUG util.py:448:   golang                    x86_64  1.22.3-1.daos.el8                    go-build-toolchain:PR-25:16                            53 M

golang is installed from the PR.

It does have the problem however that the Ubuntu build fails because the go-build-toolchain PR does not build for Ubuntu.

It's going to need to however, as Ubuntu has just become an officially supported distro for DAOS 2.8.

That said, this is an inherent problem with CI_PR_REPOS. Unlike the PR-repos[-<distro>]: commit pragmas CI_PR_REPOS doesn't have per-distro control, so the implementation could use commit pragmas for the downstream test instead of setting the parameter.

But I think given that the go-build-toolchain is about the only project that requires the build stage in the downstream job, we can punt on using pragmas instead of parameters and just have go-build-toolchain build for Ubuntu also.

[grom72]

@brianjmurrell please take a look at: build.hpdd.intel.com/job/daos-stack/job/daos/job/ci-daos-stack-go-build-toolchain-PR-25-master/31/parameters and confirm that the solution works as you expect.

Excellent work! It does work as expected, for the most part. As we can see in the EL8 RPM build log:

[2024-05-22T15:07:55.555Z] DEBUG util.py:448:   golang                    x86_64  1.22.3-1.daos.el8                    go-build-toolchain:PR-25:16                            53 M

golang is installed from the PR.

It does have the problem however that the Ubuntu build fails because the go-build-toolchain PR does not build for Ubuntu.

It's going to need to however, as Ubuntu has just become an officially supported distro for DAOS 2.8.

That said, this is an inherent problem with CI_PR_REPOS. Unlike the PR-repos[-<distro>]: commit pragmas CI_PR_REPOS doesn't have per-distro control, so the implementation could use commit pragmas for the downstream test instead of setting the parameter.

But I think given that the go-build-toolchain is about the only project that requires the build stage in the downstream job, we can punt on using pragmas instead of parameters and just have go-build-toolchain build for Ubuntu also.

Can we somehow split the work as Ubuntu is required for 2.8 but the new go-build-toolchain is required for 2.6?

[brianjmurrell]

Can we somehow split the work as Ubuntu is required for 2.8 but the new go-build-toolchain is required for 2.6?

The problem is that we have no mechanism to skip the Ubuntu build downstream when using CI_PR_REPOS and so every go-build-toolchain PR is going to fail it's downstream testing.

You could switch to using commit pragmas in the downstream testing (there is facility for that -- or almost at least perhaps) but given the simplicity of the packaging for the go-build-toolchain repo, a debian/ dir for it would probably be pretty trivial. There is a ticket already created specifically for that effort, FWIW, as it is going to be necessary sooner than later anyway.

[daosbuild1]

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14387/9/testReport/

[daosbuild1]

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14387/10/testReport/