daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-15841 control: Improve coverage and fs mocking in storage packages

Open tanabarr opened this issue 1 year ago • 11 comments

Some control-plane storage unit tests are inadvertently calling into test runner host OS filesystem. Fix by consolidating SystemProvider interface and applying storage subsystem provider stubs by default in the unit test framework. As a result coverage can be improved by exercising a greater number of code paths.

Features: control Required-githooks: true

Before requesting gatekeeper:

  • [ ] Two review approvals and any prior change requests have been resolved.
  • [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • [ ] Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • [ ] Commit messages follows the guidelines outlined here.
  • [ ] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • [ ] You are the appropriate gatekeeper to be landing the patch.
  • [ ] The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • [ ] Githooks were used. If not, request that user install them and check copyright dates.
  • [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • [ ] All builds have passed. Check non-required builds for any new compiler warnings.
  • [ ] Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • [ ] If applicable, the PR has addressed any potential version compatibility issues.
  • [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • [ ] Extra checks if forced landing is requested
    • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • [ ] No new NLT or valgrind warnings. Check the classic view.
    • [ ] Quick-build or Quick-functional is not used.
  • [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

tanabarr avatar May 15 '24 13:05 tanabarr

Ticket title is 'Improve test coverage and filesystem mocking in storage packages' Status is 'In Review' Labels: 'Go,unit_test' https://daosio.atlassian.net/browse/DAOS-15841

github-actions[bot] avatar May 15 '24 13:05 github-actions[bot]

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14379/1/execution/node/381/log

daosbuild1 avatar May 15 '24 13:05 daosbuild1

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14379/1/execution/node/386/log

daosbuild1 avatar May 15 '24 13:05 daosbuild1

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14379/1/execution/node/342/log

daosbuild1 avatar May 15 '24 13:05 daosbuild1

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14379/1/execution/node/308/log

daosbuild1 avatar May 15 '24 13:05 daosbuild1

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14379/3/execution/node/387/log

daosbuild1 avatar May 15 '24 13:05 daosbuild1

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14379/3/execution/node/359/log

daosbuild1 avatar May 15 '24 13:05 daosbuild1

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14379/3/execution/node/343/log

daosbuild1 avatar May 15 '24 13:05 daosbuild1

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14379/3/execution/node/380/log

daosbuild1 avatar May 15 '24 13:05 daosbuild1

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14379/3/execution/node/339/log

daosbuild1 avatar May 15 '24 13:05 daosbuild1

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14379/3/execution/node/355/log

daosbuild1 avatar May 15 '24 14:05 daosbuild1