daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-15846 common: Use tenv for rsvc_tests

Open liw opened this issue 1 year ago • 4 comments

Looks rsvc_tests should use tenv instead of unit_env.

Before requesting gatekeeper:

  • [ ] Two review approvals and any prior change requests have been resolved.
  • [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • [ ] Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • [ ] Commit messages follows the guidelines outlined here.
  • [ ] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • [ ] You are the appropriate gatekeeper to be landing the patch.
  • [ ] The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • [ ] Githooks were used. If not, request that user install them and check copyright dates.
  • [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • [ ] All builds have passed. Check non-required builds for any new compiler warnings.
  • [ ] Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • [ ] If applicable, the PR has addressed any potential version compatibility issues.
  • [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • [ ] Extra checks if forced landing is requested
    • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • [ ] No new NLT or valgrind warnings. Check the classic view.
    • [ ] Quick-build or Quick-functional is not used.
  • [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

liw avatar May 15 '24 00:05 liw

Ticket title is 'Failed to build rsvc_tests with Bullseye' Status is 'In Review' https://daosio.atlassian.net/browse/DAOS-15846

github-actions[bot] avatar May 15 '24 00:05 github-actions[bot]

@daos-stack/dev-build-owners, please review this carefully, for I confess I don't really know what I'm doing here. Thank you.

liw avatar May 15 '24 05:05 liw

@daos-stack/daos-gatekeeper, since this is a build system fix for a unit test, I assume that it's not too rude to ignore functional testing and CI environment issues?

liw avatar May 16 '24 00:05 liw

@daos-stack/daos-gatekeeper, since this is a build system fix for a unit test, I assume that it's not too rude to ignore functional testing and CI environment issues?

yes. you could also use Skip-func-test: true pragma in your commit fwiw. i still do not see a review from build owners and your comment on the PR mentions that you want to wait for a review from one? @jolivier23 ? the commit message also needs to be updated as it cannot be a question :-)

mchaarawi avatar May 16 '24 12:05 mchaarawi