daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-15420 pool: Clean up ds_pool_svc_<op>

Open liw opened this issue 1 year ago • 10 comments

Convert

ds_pool_svc_check_evict
ds_pool_svc_query_target
ds_pool_svc_get_prop
ds_pool_svc_set_prop
ds_pool_svc_target_update_state
ds_pool_svc_update_acl
ds_pool_svc_delete_acl
ds_pool_svc_upgrade
ds_pool_extend

to the dsc_pool_svc_call framework, so that they will

  • time out, instead of hanging forever, if PSs are unavailable, and
  • respond much faster in common cases thanks to exponential backoffs.

The req_time variable in dsc_pool_svc_call is part of the operation identifier, and should therefore retain its value across retries.

Features: pool

Before requesting gatekeeper:

  • [ ] Two review approvals and any prior change requests have been resolved.
  • [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • [ ] Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • [ ] Commit messages follows the guidelines outlined here.
  • [ ] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • [ ] You are the appropriate gatekeeper to be landing the patch.
  • [ ] The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • [ ] Githooks were used. If not, request that user install them and check copyright dates.
  • [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • [ ] All builds have passed. Check non-required builds for any new compiler warnings.
  • [ ] Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • [ ] If applicable, the PR has addressed any potential version compatibility issues.
  • [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • [ ] Extra checks if forced landing is requested
    • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • [ ] No new NLT or valgrind warnings. Check the classic view.
    • [ ] Quick-build or Quick-functional is not used.
  • [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

liw avatar Mar 21 '24 07:03 liw

Ticket title is 'Clean up engine-side PS client functions like ds_pool_svc_check_evict' Status is 'In Review' https://daosio.atlassian.net/browse/DAOS-15420

github-actions[bot] avatar Mar 21 '24 07:03 github-actions[bot]

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14036/1/execution/node/1198/log

daosbuild1 avatar Mar 21 '24 18:03 daosbuild1

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14036/2/testReport/

daosbuild1 avatar Mar 25 '24 12:03 daosbuild1

Test stage Functional Hardware Medium Verbs Provider completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14036/3/testReport/

daosbuild1 avatar Mar 29 '24 16:03 daosbuild1

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14036/3/testReport/

daosbuild1 avatar Mar 29 '24 19:03 daosbuild1

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14036/6/execution/node/1405/log

daosbuild1 avatar Apr 18 '24 15:04 daosbuild1

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14036/8/execution/node/1174/log

daosbuild1 avatar Apr 26 '24 18:04 daosbuild1

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14036/11/execution/node/1455/log

daosbuild1 avatar May 08 '24 23:05 daosbuild1

daos_test/rebuild_simple: DAOS-15431

liw avatar May 09 '24 11:05 liw

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14036/13/execution/node/1408/log

daosbuild1 avatar May 16 '24 07:05 daosbuild1