daos icon indicating copy to clipboard operation
daos copied to clipboard
verified publisher icon daos-stack

DAOS-15277 cart: Strengthen incoming tag checks (#13934)

Open liw opened this issue 1 year ago • 4 comments

Before an engine knows its rank, it skips both the rank and the tag checks for incoming RPCs. Because we progress the SWIM context before knowing the rank of the engine, we handle RPCs sent to our SWIM tag in the SWIM xstream. Some of these RPCs may be sent to a different tag of a previous DAOS system, whose network address happens to be the same as that of our SWIM tag! Hence, this patch strengthens crt_rpc_common_hdlr to perform the tag check regardless of self_rank.

Before requesting gatekeeper:

  • [ ] Two review approvals and any prior change requests have been resolved.
  • [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • [ ] Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • [ ] Commit messages follows the guidelines outlined here.
  • [ ] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • [ ] You are the appropriate gatekeeper to be landing the patch.
  • [ ] The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • [ ] Githooks were used. If not, request that user install them and check copyright dates.
  • [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • [ ] All builds have passed. Check non-required builds for any new compiler warnings.
  • [ ] Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • [ ] If applicable, the PR has addressed any potential version compatibility issues.
  • [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • [ ] Extra checks if forced landing is requested
    • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • [ ] No new NLT or valgrind warnings. Check the classic view.
    • [ ] Quick-build or Quick-functional is not used.
  • [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

liw avatar Mar 16 '24 00:03 liw

Bug-tracker data: Errors are Unable to load ticket data https://daosio.atlassian.net/browse/DAOS-15277

github-actions[bot] avatar Mar 16 '24 00:03 github-actions[bot]

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14006/1/testReport/

daosbuild1 avatar Mar 16 '24 01:03 daosbuild1

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14006/2/testReport/

daosbuild1 avatar Mar 18 '24 00:03 daosbuild1

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14006/2/execution/node/1245/log

daosbuild1 avatar Mar 18 '24 03:03 daosbuild1

Thanks for the prompt response, Alex.

liw avatar Mar 21 '24 00:03 liw