daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-14845 object: retry migration for retriable failure (#13590)

Open wangdi1 opened this issue 1 year ago • 4 comments

To avoid retry rebuild and reclaim, let's retry rebuild until further pool map changes, in that case, it should fail the current rebuild, and further rebuild will resolve the failure.

various fixs about rebuild if PS leader keeps changing during rebuild.

Move migrate max ULT control to migrate_obj_iter_cb() to make sure max ULT count will not exceed the setting.

Change the yield freq from 128 to 16 to make sure the object

Optimize migrate memory usage

  • Add max ULT control for all targets on xstream, so the object being migrated can not exceed MIGRATE_MAX_ULT.

  • Add each target max ULT control, so each target migrate ULT can not exceed MIGRATE_MAX_ULT/dss_tgt_nr.

  • Add migrate_cont_open to avoid dsc_cont_open and dsc_pool_open for each object and dkey migration.

Features: rebuild Required-githooks: true

Before requesting gatekeeper:

  • [ ] Two review approvals and any prior change requests have been resolved.
  • [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • [ ] Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • [ ] Commit messages follows the guidelines outlined here.
  • [ ] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • [ ] You are the appropriate gatekeeper to be landing the patch.
  • [ ] The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • [ ] Githooks were used. If not, request that user install them and check copyright dates.
  • [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • [ ] All builds have passed. Check non-required builds for any new compiler warnings.
  • [ ] Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • [ ] If applicable, the PR has addressed any potential version compatibility issues.
  • [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • [ ] Extra checks if forced landing is requested
    • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • [ ] No new NLT or valgrind warnings. Check the classic view.
    • [ ] Quick-build or Quick-functional is not used.
  • [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

wangdi1 avatar Mar 15 '24 15:03 wangdi1

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13993/1/execution/node/204/log

daosbuild1 avatar Mar 15 '24 15:03 daosbuild1

Bug-tracker data: Ticket title is 'timeout for mdtest after killing one rank FTEST_erasurecode.EcodOnlineRebuildMdtest.1-./erasurecode/online_rebuild_mdtest.py' Status is 'Resolved' Labels: 'ci_impact,pr_test,release/2.4' https://daosio.atlassian.net/browse/DAOS-14845

github-actions[bot] avatar Mar 15 '24 15:03 github-actions[bot]

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13993/1/testReport/

daosbuild1 avatar Mar 15 '24 16:03 daosbuild1

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13993/1/execution/node/1293/log

daosbuild1 avatar Mar 16 '24 01:03 daosbuild1

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13993/2/execution/node/204/log

daosbuild1 avatar Mar 19 '24 01:03 daosbuild1

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13993/3/execution/node/1307/log

daosbuild1 avatar Mar 19 '24 20:03 daosbuild1

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13993/4/execution/node/1474/log

daosbuild1 avatar Mar 21 '24 15:03 daosbuild1

@jolivier23 or @gnailzenh @NiuYawei , this PR's commit 1 is backport from master branch, commit 2 is a small patch from me to fix a rebuild cannot complete bug. Now all the rebuild tests can pass, please consider to land it, this is needed for 2.4.3, thx.

liuxuezhao avatar Mar 26 '24 01:03 liuxuezhao