daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-14574 test: Query the pool to detect whether the pool is destroy…

Open shimizukko opened this issue 1 year ago • 2 comments

…ed (#13903)

The test, pool/create_all_vm.py test_recycle_pools_vm(), destroyes a pool, then immediately creates another pool. Running this sequence on a VM node intermittently causes an error during create.

To resolve this issue, query the pool to detect whether the pool is destroyed after pool destroy is called. If the query causes a CommandFailure, the pool must have been destroyed. If the query works, the pool still exists and we should wait more.

Increase timeout for create_all_hw.yaml due to timeout.

Skip-unit-tests: true Skip-fault-injection-test: true Test-tag: test_recycle_pools_vm test_recycle_pools_hw Test-repeat: 5

Before requesting gatekeeper:

  • [ ] Two review approvals and any prior change requests have been resolved.
  • [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • [ ] Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • [ ] Commit messages follows the guidelines outlined here.
  • [ ] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • [ ] You are the appropriate gatekeeper to be landing the patch.
  • [ ] The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • [ ] Githooks were used. If not, request that user install them and check copyright dates.
  • [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • [ ] All builds have passed. Check non-required builds for any new compiler warnings.
  • [ ] Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • [ ] If applicable, the PR has addressed any potential version compatibility issues.
  • [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • [ ] Extra checks if forced landing is requested
    • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • [ ] No new NLT or valgrind warnings. Check the classic view.
    • [ ] Quick-build or Quick-functional is not used.
  • [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

shimizukko avatar Mar 06 '24 21:03 shimizukko

Bug-tracker data: Ticket title is 'pool/create_all_vm.py:PoolCreateAllVmTests.test_recycle_pools_vm - ERROR: dmg: Host without SCM storage' Status is 'In Review' Labels: 'ci_impact,pr_test,request_for_2.4.3,scrubbed,test_fix,triaged' https://daosio.atlassian.net/browse/DAOS-14574

github-actions[bot] avatar Mar 06 '24 21:03 github-actions[bot]

The unclean part is import time.

shimizukko avatar Mar 06 '24 22:03 shimizukko