daos icon indicating copy to clipboard operation
daos copied to clipboard
verified publisher icon daos-stack

DAOS-15339 sched: suppress unnecessary warn message

Open NiuYawei opened this issue 1 year ago • 4 comments

The warn message for too large QD was introduced for sanity check in typical settings which has only handful containers, but it could be easily triggered when there are many containers.

This message has been removed in master, let's suppress it for 2.4.

Required-githooks: true

Before requesting gatekeeper:

  • [ ] Two review approvals and any prior change requests have been resolved.
  • [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • [ ] Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • [ ] Commit messages follows the guidelines outlined here.
  • [ ] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • [ ] You are the appropriate gatekeeper to be landing the patch.
  • [ ] The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • [ ] Githooks were used. If not, request that user install them and check copyright dates.
  • [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • [ ] All builds have passed. Check non-required builds for any new compiler warnings.
  • [ ] Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • [ ] If applicable, the PR has addressed any potential version compatibility issues.
  • [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • [ ] Extra checks if forced landing is requested
    • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • [ ] No new NLT or valgrind warnings. Check the classic view.
    • [ ] Quick-build or Quick-functional is not used.
  • [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

NiuYawei avatar Mar 05 '24 02:03 NiuYawei

Bug-tracker data: Ticket title is 'soak: soak stress: server CRIT src/engine/sched.c:849 set_req_limit() Too large QD' Status is 'In Review' Labels: 'soak' Errors are Unknown component https://daosio.atlassian.net/browse/DAOS-15339

github-actions[bot] avatar Mar 05 '24 02:03 github-actions[bot]

Test stage Functional Hardware Medium Verbs Provider completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13933/1/testReport/

daosbuild1 avatar Mar 05 '24 21:03 daosbuild1

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13933/2/testReport/

daosbuild1 avatar Mar 18 '24 01:03 daosbuild1

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13933/2/execution/node/1312/log

daosbuild1 avatar Mar 18 '24 05:03 daosbuild1

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13933/3/execution/node/1306/log

daosbuild1 avatar Mar 19 '24 12:03 daosbuild1

@daos-stack/daos-gatekeeper , All CI tests passed, but clang build on leap15 failed due to a dnf upgrade error. This PR just changed one line of debug message, I think we'd force land it.

NiuYawei avatar Mar 26 '24 01:03 NiuYawei