daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-15316 object: fix some coverity issues

Open Nasf-Fan opened this issue 1 year ago • 11 comments

Contain the fixes for CID: 1965549/1965550/1972512

Before requesting gatekeeper:

  • [ ] Two review approvals and any prior change requests have been resolved.
  • [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • [ ] Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • [ ] Commit messages follows the guidelines outlined here.
  • [ ] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • [ ] You are the appropriate gatekeeper to be landing the patch.
  • [ ] The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • [ ] Githooks were used. If not, request that user install them and check copyright dates.
  • [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • [ ] All builds have passed. Check non-required builds for any new compiler warnings.
  • [ ] Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • [ ] If applicable, the PR has addressed any potential version compatibility issues.
  • [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • [ ] Extra checks if forced landing is requested
    • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • [ ] No new NLT or valgrind warnings. Check the classic view.
    • [ ] Quick-build or Quick-functional is not used.
  • [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Nasf-Fan avatar Mar 01 '24 01:03 Nasf-Fan

Ticket title is '[coverity] 1965549 Resource leak' Status is 'In Progress' Labels: 'coverity' https://daosio.atlassian.net/browse/DAOS-15316

github-actions[bot] avatar Mar 01 '24 01:03 github-actions[bot]

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13905/2/execution/node/1447/log

daosbuild1 avatar Mar 02 '24 01:03 daosbuild1

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13905/3/execution/node/1149/log

daosbuild1 avatar Mar 03 '24 06:03 daosbuild1

telemetry_list failed for DAOS-15337, to be retested.

Nasf-Fan avatar Mar 04 '24 01:03 Nasf-Fan

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-13905/5/display/redirect

daosbuild1 avatar Mar 06 '24 20:03 daosbuild1

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13905/7/execution/node/1174/log

daosbuild1 avatar Mar 07 '24 17:03 daosbuild1

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13905/8/execution/node/1198/log

daosbuild1 avatar Mar 08 '24 04:03 daosbuild1

Failed for unrelated NLT warning, to be retested.

Nasf-Fan avatar Mar 14 '24 02:03 Nasf-Fan

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13905/14/execution/node/1535/log

daosbuild1 avatar Mar 15 '24 12:03 daosbuild1

rebuild_ec timeout because of DAOS-14208.

Nasf-Fan avatar Mar 15 '24 15:03 Nasf-Fan

rebuild_ec timeout because of DAOS-14208.

As explained in the ticket, the logs shows it is a new issue in network layer. You may merge to latest maser and test again to see if can hit it again.

liuxuezhao avatar Mar 17 '24 10:03 liuxuezhao