daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-15127 object: avoid repeated conversion for EC recx

Open Nasf-Fan opened this issue 1 year ago • 7 comments

The collective query logic may do multiple levels result reduce to find out the max or min recx. For each raw EC recx returned from VOS, the collective query reduce logic needs to convert it only for once. When compare two EC recxs, both of them need to be converted as daos ext (for data shard).

Skip-func-vm-test-el8: true Features: ec rebuild

Before requesting gatekeeper:

  • [ ] Two review approvals and any prior change requests have been resolved.
  • [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • [ ] Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • [ ] Commit messages follows the guidelines outlined here.
  • [ ] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • [ ] You are the appropriate gatekeeper to be landing the patch.
  • [ ] The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • [ ] Githooks were used. If not, request that user install them and check copyright dates.
  • [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • [ ] All builds have passed. Check non-required builds for any new compiler warnings.
  • [ ] Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • [ ] If applicable, the PR has addressed any potential version compatibility issues.
  • [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • [ ] Extra checks if forced landing is requested
    • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • [ ] No new NLT or valgrind warnings. Check the classic view.
    • [ ] Quick-build or Quick-functional is not used.
  • [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Nasf-Fan avatar Feb 27 '24 12:02 Nasf-Fan

Ticket title is 'erasurecode/multiple_failure.py:EcodOnlineMultFail.test_ec_multiple_rank_failure fails with FAIL-IOR command issued warnings.' Status is 'In Progress' Labels: 'ci_impact,md_on_ssd,scrubbed,triaged,weekly_test' https://daosio.atlassian.net/browse/DAOS-15127

github-actions[bot] avatar Feb 27 '24 12:02 github-actions[bot]

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13880/1/execution/node/1446/log

daosbuild1 avatar Feb 28 '24 14:02 daosbuild1

network_failure.py and server_rank_failure.py failed for DOAS-14242.

Nasf-Fan avatar Feb 28 '24 15:02 Nasf-Fan

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13880/1/execution/node/1538/log

daosbuild1 avatar Feb 28 '24 23:02 daosbuild1

test_ec_online_rebuild_fio failed for DAOS-15007, DAOS-15273. test_nvme_pool_extend failed for DAOS-14600. nvme-pool_extend failed for DAOS-15277. erasurecode/rank_failure.py:EcodRunIoConf.test_daos_run_io_conf failed for DAOS-15059.

Nasf-Fan avatar Feb 29 '24 00:02 Nasf-Fan

test_rebuild_widely_striped failed for DAOS-14780.

Nasf-Fan avatar Feb 29 '24 00:02 Nasf-Fan

Replaced by https://github.com/daos-stack/daos/pull/13923

Nasf-Fan avatar Mar 04 '24 16:03 Nasf-Fan