daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-14248 engine: strengthen signals handling

Open bfaccini opened this issue 2 years ago • 8 comments

Re-raise signal in all cases. Also catch SIGTRAP. Re-add USR1/USR2 signals to waiting set when triggered.

Required-githooks: true

Before requesting gatekeeper:

  • [ ] Two review approvals and any prior change requests have been resolved.
  • [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • [ ] Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • [ ] Commit messages follows the guidelines outlined here.
  • [ ] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • [ ] You are the appropriate gatekeeper to be landing the patch.
  • [ ] The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • [ ] Githooks were used. If not, request that user install them and check copyright dates.
  • [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • [ ] All builds have passed. Check non-required builds for any new compiler warnings.
  • [ ] Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • [ ] If applicable, the PR has addressed any potential version compatibility issues.
  • [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • [ ] Extra checks if forced landing is requested
    • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • [ ] No new NLT or valgrind warnings. Check the classic view.
    • [ ] Quick-build or Quick-functional is not used.
  • [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

bfaccini avatar Sep 11 '23 10:09 bfaccini

Bug-tracker data: Ticket title is 'dump of engine's ULTs stacks only works one time' Status is 'In Review' https://daosio.atlassian.net/browse/DAOS-14248

github-actions[bot] avatar Sep 11 '23 10:09 github-actions[bot]

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13031/1/execution/node/1119/log

daosbuild1 avatar Sep 11 '23 13:09 daosbuild1

Test stage Functional Hardware Medium Verbs Provider completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13031/2/testReport/

daosbuild1 avatar Sep 14 '23 23:09 daosbuild1

Only failure in CI is :

Test Hardware / Functional Hardware Medium Verbs Provider / UPGRADE2: upgrade with dfs - FTEST_daos_test.DAOS_upgrade
Stacktrace
0x16 != 0
src/tests/suite/daos_upgrade.c:255: error: Failure!

looks definitelly unrelated and already being addressed by DAOS-14188 JIRA ticket, where fix/PR-12883 still has not landed.

bfaccini avatar Sep 15 '23 09:09 bfaccini

Ticket title is 'dump of engine's ULTs stacks only works one time' Status is 'In Review' https://daosio.atlassian.net/browse/DAOS-14248

github-actions[bot] avatar May 17 '24 08:05 github-actions[bot]

@johannlombardi and @ashleypittman , please could you tell me if this PR is OK for you ?

knard38 avatar May 27 '24 06:05 knard38

@johannlombardi and @ashleypittman , please could you tell me if this PR is OK for you ?

knard38 avatar Jun 10 '24 07:06 knard38

@ashleypittman , please could you tell me if this PR is OK for you ?

knard38 avatar Jun 24 '24 06:06 knard38

@ashleypittman , please could you tell me if this PR is OK for you ?

knard38 avatar Jul 26 '24 12:07 knard38

This PR is 4 months stale and needs to be updated and testing reran.

daltonbohning avatar Sep 16 '24 15:09 daltonbohning

This PR is 4 months stale and needs to be updated and testing reran.

Merged and send to CI. Sadly, I will not be able to investigate on eventual CI errors as I have still not received my new company laptop. Hopefully everything will go smoothly ;-)

knard38 avatar Sep 18 '24 07:09 knard38

This PR is 4 months stale and needs to be updated and testing reran.

Still good... my new company laptop should not be needed for this PR :-)

knard38 avatar Sep 19 '24 07:09 knard38