DAOS-11406 rdb: Use VOS local TXs

[liw]

Every RDB (update) TX invokes multiple VOS writes, each of which performs a WAL commit. This patch reduces those WAL commits to one per RDB TX by utilizing the new VOS local TXs to group all VOS writes of one RDB TX into one VOS local TX.

• An rdb_vos_tx_t handle is introduced to hide the vos/dtx details from the rest of rdb.

• Some rdb_lc_discard calls are no longer necessary, for the VOS local TX mechanism will discard uncommited writes more efficiently.

• Some "nvops" ("number of VOS TX operations") functions are added to provide dtx_begin with an upper bound of the number of VOS TX operations that will be invoked using a VOS TX handle. Hopefully this will become unnecessary in the future.

• The rdb_tx_hdr decoding in rdb_tx_apply should use the actual length of the data, rather than the expected length.

• Two places related to rdb_tx_hdr need to be refactored a bit in order to avoid compiler warnings along the line of "hdr may be used uninitialized". It's unclear why the compiler warnings suddenly come up.

Before requesting gatekeeper:

• [ ] Two review approvals and any prior change requests have been resolved.
• [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
• [ ] Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
• [ ] Commit messages follows the guidelines outlined here.
• [ ] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

• [ ] You are the appropriate gatekeeper to be landing the patch.
• [ ] The PR has 2 reviews by people familiar with the code, including appropriate watchers.
• [ ] Githooks were used. If not, request that user install them and check copyright dates.
• [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
• [ ] All builds have passed. Check non-required builds for any new compiler warnings.
• [ ] Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
• [ ] If applicable, the PR has addressed any potential version compatibility issues.
• [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
• [ ] Extra checks if forced landing is requested
  • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
  • [ ] No new NLT or valgrind warnings. Check the classic view.
  • [ ] Quick-build or Quick-functional is not used.
• [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

[github-actions[bot]]

Bug-tracker data: Ticket title is 'Change RDB to use new extended VOS API' Status is 'In Progress' Labels: 'md_on_ssd' https://daosio.atlassian.net/browse/DAOS-11406

[daosbuild1]

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/2/execution/node/145/log

[liw]

@jolivier23, @kccain, just in case you are interested, I requested draft reviews to make this PR easier for you to find.

[daosbuild1]

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/2/execution/node/1242/log

[daosbuild1]

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/5/execution/node/396/log

[daosbuild1]

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/5/execution/node/362/log

[daosbuild1]

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/5/execution/node/372/log

[daosbuild1]

Test stage Build RPM on Leap 15.4 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/5/execution/node/306/log

[daosbuild1]

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/6/execution/node/388/log

[daosbuild1]

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/6/execution/node/337/log

[daosbuild1]

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/6/execution/node/364/log

[liw]

@kccain, @jolivier23, could we do an initial round of review before the VOS part is ready? I have done some basic testing with one of @janekmi's WIP commit, but the full CI testing cannot start before the VOS part is ready.

[liw]

It sounds like this patch is going to be waiting for some vos implementation to land first, so there should be some more time for that?

Yes. Absolutely. Thanks for starting the review.

[daosbuild1]

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/9/execution/node/377/log

[daosbuild1]

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/9/execution/node/323/log

[daosbuild1]

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/9/execution/node/380/log

[daosbuild1]

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/9/execution/node/363/log

[daosbuild1]

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/10/execution/node/276/log

[daosbuild1]

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/10/execution/node/273/log

[daosbuild1]

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/10/execution/node/279/log

[daosbuild1]

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/10/execution/node/303/log

[liw]

Rebased without changes to the update janekmi/local_tx2 branch.

[daosbuild1]

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-12330/15/testReport/

[daosbuild1]

Test stage Unit Test with memcheck on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-12330/15/testReport/

[github-actions[bot]]

Ticket title is 'Change RDB to use new extended VOS API' Status is 'In Review' Labels: 'md_on_ssd' https://daosio.atlassian.net/browse/DAOS-11406

[daosbuild1]

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/18/execution/node/1451/log

[liw]

daos_test/suite.py: drain_simple: Wolf IB network problem

[liw]

Rebased back to master.

[liw]

Rebased to liw/fix-dth_deferred so that testing can continue.

[liw]

Per request, starting the review process before getting the latest CI result.