daos icon indicating copy to clipboard operation
daos copied to clipboard
verified publisher icon daos-stack

DAOS-10915 csum: Scrubbing Cleanup

Open ryon-jensen opened this issue 3 years ago • 2 comments

When the csum scrubbing feature branch landed, there where some minor style and text items that needed to be resolved. This change resolves those.

Signed-off-by: Ryon Jensen [email protected]

Before requesting gatekeeper:

  • [ ] Two review approvals and any prior change requests have been resolved.
  • [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • [ ] Commit messages follows the guidelines outlined here.
  • [ ] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • [ ] You are the appropriate gatekeeper to be landing the patch.
  • [ ] The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • [ ] Githooks were used. If not, request that user install them and check copyright dates.
  • [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • [ ] All builds have passed. Check non-required builds for any new compiler warnings.
  • [ ] Sufficent testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • [ ] If applicable, the PR has addressed any potential version compatibility issues.
  • [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • [ ] Extra checks if forced landing is requested
    • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • [ ] No new NLT or valgrind warnings. Check the classic view.
    • [ ] Quick-build or Quick-functional is not used.
  • [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

ryon-jensen avatar Oct 14 '22 20:10 ryon-jensen

Bug-tracker data: Ticket title is 'Checksum Scrubbing Feature Branch Landing Cleanup' Status is 'In Review' Labels: 'checksum_scrubber' https://daosio.atlassian.net/browse/DAOS-10915

github-actions[bot] avatar Oct 14 '22 20:10 github-actions[bot]

Test stage Functional Hardware Small completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-10576/1/testReport/(root)/

daosbuild1 avatar Oct 15 '22 00:10 daosbuild1

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10576/1/execution/node/1085/log

daosbuild1 avatar Oct 15 '22 13:10 daosbuild1

I think I fixed the flake8 error.

ryon-jensen avatar Oct 17 '22 16:10 ryon-jensen

Not sure why spell check failed on a file I didn't touch??

ryon-jensen avatar Oct 18 '22 14:10 ryon-jensen

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10576/3/execution/node/1130/log

daosbuild1 avatar Oct 19 '22 04:10 daosbuild1

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10576/4/execution/node/1130/log

daosbuild1 avatar Oct 23 '22 23:10 daosbuild1

Test failures appear to be DAOS-11936

ryon-jensen avatar Oct 24 '22 15:10 ryon-jensen

Requesting forced-landing by @daos-stack/daos-gatekeeper because of known test failures.

ryon-jensen avatar Oct 24 '22 15:10 ryon-jensen

poke @daos-stack/daos-gatekeeper

ryon-jensen avatar Oct 26 '22 16:10 ryon-jensen

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10576/5/execution/node/1130/log

daosbuild1 avatar Oct 28 '22 04:10 daosbuild1

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10576/5/execution/node/1083/log

daosbuild1 avatar Oct 28 '22 06:10 daosbuild1

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-10576/6/display/redirect

daosbuild1 avatar Nov 04 '22 12:11 daosbuild1

Test stage Functional Hardware Small completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-10576/6/display/redirect

daosbuild1 avatar Nov 04 '22 13:11 daosbuild1

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-10576/6/display/redirect

daosbuild1 avatar Nov 04 '22 13:11 daosbuild1

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10576/7/execution/node/1083/log

daosbuild1 avatar Nov 05 '22 20:11 daosbuild1

Known test failure: https://daosio.atlassian.net/browse/DAOS-12031. Requesting force landing.

ryon-jensen avatar Nov 07 '22 22:11 ryon-jensen

Had a conflict so merged with master. Rebuilding ...

ryon-jensen avatar Nov 10 '22 16:11 ryon-jensen

On the previous build, everything passed. I had to remove a duplicate from a list in the jira_query script so used pragmas to not build or test. This is ready to land.

ryon-jensen avatar Nov 18 '22 23:11 ryon-jensen

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10576/12/execution/node/1130/log

daosbuild1 avatar Nov 29 '22 06:11 daosbuild1

Test failure is known

  • test_nvme_pool_extend: https://daosio.atlassian.net/browse/DAOS-12073

Requesting force landing

ryon-jensen avatar Nov 29 '22 21:11 ryon-jensen