daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-11911 test: Fix launch.py error reporting

Open phender opened this issue 2 years ago • 1 comments

If launch.py experienced an error before it could establish a file handler for logging debug messages to a file, it could fail without providing the reason for the failure. This could happen when running manually if the python avocado libraries where not installed or misconfigured. The console logger will now report all messages until the file handler is configured, at which point the console logger will be updated to only report info messages.

Required-githooks: true

Signed-off-by: Phil Henderson [email protected]

Before requesting gatekeeper:

  • [ ] Two review approvals and any prior change requests have been resolved.
  • [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • [x] Commit messages follows the guidelines outlined here.
  • [x] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • [ ] You are the appropriate gatekeeper to be landing the patch.
  • [ ] The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • [ ] Githooks were used. If not, request that user install them and check copyright dates.
  • [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • [ ] All builds have passed. Check non-required builds for any new compiler warnings.
  • [ ] Sufficent testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • [ ] If applicable, the PR has addressed any potential version compatibility issues.
  • [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • [ ] Extra checks if forced landing is requested
    • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • [ ] No new NLT or valgrind warnings. Check the classic view.
    • [ ] Quick-build or Quick-functional is not used.
  • [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

phender avatar Oct 14 '22 19:10 phender

Bug-tracker data: Ticket title is 'launch.py: print error even when logging is not setup' Status is 'In Progress' Labels: 'triaged' https://daosio.atlassian.net/browse/DAOS-11911

github-actions[bot] avatar Oct 14 '22 19:10 github-actions[bot]