daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-11892 object: add spec shard case in tgts_query

Open wangdi1 opened this issue 2 years ago • 1 comments

Add spec shard case in tgts_query to avoid any spec shard fetch will do EC degraded fetch. Especially if it is used by EC aggregation remote parity fetch to fetch parity shard, improper spec shard handling might cause server segfault.

Required-githooks: true

Signed-off-by: Di Wang [email protected]

Before requesting gatekeeper:

  • [ ] Two review approvals and any prior change requests have been resolved.
  • [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • [ ] Commit messages follows the guidelines outlined here.
  • [ ] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • [ ] You are the appropriate gatekeeper to be landing the patch.
  • [ ] The PR has 2 reviews by people familiar with the code.
  • [ ] Any appropriate watchers have had a chance to review the PR.
  • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
  • [ ] Githooks were used. If not, there is a sufficient reason to move forward. Check copyrights if githooks were not used.
  • [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • [ ] All builds have passed. Check non-required builds to ensure they don't indicate any problem such as a compiler warning on extraneous platforms.
  • [ ] No new NLT or valgrind warnings. Check the classic view. This step should only matter if the build requires force landing.
  • [ ] Ensure sufficent testing is done. Check feature pragmas and test tags. Check that tests skipped for the ticket are run and now pass with the changes.
  • [ ] Quick-build or Quick-functional is not used.
  • [ ] Pay attention to PRs that may affect compatibility between versions and ensure it has been addressed.
  • [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • [ ] Check the commit message when landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

wangdi1 avatar Oct 12 '22 05:10 wangdi1

Bug-tracker data: Ticket title is 'src/object/obj_ec.h:596: obj_iod_idx_vos2parity: Assertion `0' failed.' Status is 'In Review' Labels: 'scrubbed' Job should run at elevated priority (1) https://daosio.atlassian.net/browse/DAOS-11892

github-actions[bot] avatar Oct 12 '22 05:10 github-actions[bot]

Is this a cherry-pick?

jolivier23 avatar Oct 24 '22 17:10 jolivier23

Is this a cherry-pick?

oh, 2.4 changed a lot here, so it is not cherry-pick.

wangdi1 avatar Oct 24 '22 17:10 wangdi1

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10546/2/execution/node/1197/log

daosbuild1 avatar Dec 20 '22 02:12 daosbuild1

is this a clean cherry-pick ?

No, it is not.

wangdi1 avatar Jan 11 '23 19:01 wangdi1

Ready for landing? please ask gatekeeper if so then. Thanks.

johannlombardi avatar Jan 17 '23 15:01 johannlombardi