Daniel
Daniel
I can't see Theos folder linked in your gptfdisk directory.
I see now... you have cloned the latest gptfdisk and it seems to have broken my patch. Just grab an older commit. e.g. `git reset --hard 28809faae4da171e2a2472817e516cef5e850d24`
thanks. gona give it a shot.
Hello @pirat89 thanks for the review! I've hopefully addressed all your remarks now.
I've just updated the PR. It now: - builds both signed DDI and unsigned raw image (as before) - there are two sysupdate files, one for the signed and one...
> Are you sure we actually need Azure CLI? This is normally only needed when signing manually. In CI, you're more likely to use a managed identity or a token...
I've just reworked the PR. Now instead of building the sysext directly using `systemd-repart`, I keep the original workflow and then wrap the `.raw` file into a signed DDI using...
> > I've just reworked the PR. Now instead of building the sysext directly using `systemd-repart`, I keep the original workflow and then wrap the `.raw` file into a signed...
I've just tested using erofs compression and without (using `SYSTEMD_REPART_MKFS_OPTIONS_EROFS="-zlz4hc,12 -C65536 -Efragments,ztailpacking"`). There seems to be negligible (8MB difference), so I'm not sure if it's worth the double compression. #...
I think, I've fixed most of the stuff now. To sum it up: - we don't use FS compression for the built-in sysexts (they'll get compressed by btrfs when placed...