Dan Yeaw

Results 390 comments of Dan Yeaw

@vm03 could we please merge this? Thanks!

I can't reproduce this issue with the latest master version. I think this is fixed by #63, since python_dateutil is now installed using the wheel.

For Gaphor we did something similar using a bash script: https://www.github.com/flathub/org.gaphor.Gaphor/tree/master/depends.sh

I can reproduce this issue in the latest master version. ``` (.env) dan@dan-Librem-13-v2:~/Projects/flatpak-builder-tools/pip$ python flatpak-pip-generator pyqt5 Collecting pyqt5 Downloading https://files.pythonhosted.org/packages/12/63/a7a32557fdce42b1ddf2353d9e2a576143376046ead0b1918fd4cfe01b90/PyQt5-5.13.1-5.13.1-cp35.cp36.cp37.cp38-abi3-manylinux1_x86_64.whl (62.1MB) |████████████████████████████████| 62.2MB 188kB/s Saved /tmp/pip-generator-python3-pyqt5-8lbye91x/PyQt5-5.13.1-5.13.1-cp35.cp36.cp37.cp38-abi3-manylinux1_x86_64.whl Collecting PyQt5_sip=4.19.19 Downloading https://files.pythonhosted.org/packages/37/15/de717dffb8b7a9f6e976dcb3611b31f62213527f21734462fcdbd6744e43/PyQt5_sip-12.7.0-cp38-cp38-manylinux1_x86_64.whl...

Hi @radoering, I rebased this on top of the main branch. Unfortunately mypy gives a `Unexpected keyword argument "encoding" for "check_call"`.

Hi @radoering, thanks again for the feedback. I created https://github.com/python/typeshed/issues/12084 and added a type ignore.

Is this one ready to merge now?

@dimbleby, I'm probably done working on this one to be honest. I think this gets things most of the way there, and eventually Poetry could adopt the Ruff PLW1514 rule...

Hi @radoering, thanks for the teamwork on this.