Daniel Woste

Results 241 comments of Daniel Woste

Maybe a solution would be to make a pixel-by-pixel comparison with a golden sample, which got checked once manually. There is a question on PyMuPDF, which is discussing this: https://github.com/pymupdf/PyMuPDF/issues/584...

The last point can be easily done by matrix tests. Which are supported by github actions. Sphinx-Needs does this by creating different test-envs based on python, sphinx and docutils versions....

I think so, yes. May be the easiest solution as all other PDF libraries are more low-level.

Thanks for the bug report :+1: From the first look, numpydoc seems to put the content inside a table, which column configuration is not correct. We need to check the...

Thanks for the information and your spend time to get it running. :+1: Never thought weasyprint would be working with windows. I keep this issue open as a reminder for...

@j123b567, you are right, the folder structure of `static/styles/sources` is given for the theme. But for me all the other scenarios are still possible, using `html_css` or `app.add_css_file()`. But for...

Just reviewed #94 and it looks good to me. If nobody has any concerns with #94, I will merge it soon.

Hehe, now we have two similar solutions #91 and #94 :) Good work for both of you, any chance you two build a consense which one to take :) For...

Generally, it is a good idea to use `html_theme_options` internally and overwrite it initially with `simplepdf_theme_options`. However, I can roughly remember trying this at the beginning of this project and...

> There is another issue - `simplepdf_vars` and `simplepdf_theme_options` are used only in the theme so if the registration of these variables (`app.add_config_value`) should be also moved to the theme...