social-auth-plugin icon indicating copy to clipboard operation
social-auth-plugin copied to clipboard

Hardcoded keys in code

Open kof opened this issue 11 years ago • 4 comments

I believe the best way to get keys is to read them from config.xml

I am not ios developer, so not sure if you are able to access it already from some variable, because cordova does read this file already in CDVViewController.m ... it uses CDVConfigParser.

At the end user needs to put keys in the root config.xml, then do cordova prepare -> key lands in config.xml of each platform.

kof avatar Jun 09 '14 17:06 kof

I would like you to help implementing this but I have no idea of obj-c

kof avatar Jun 09 '14 17:06 kof

Another good way would be to set this keys from javascript and provide api for that.

kof avatar Jun 09 '14 20:06 kof

Bein able to set the keys from javascript is anyways a very good idea. This way we could change them live in production ... f.e. if twitter restricts a key, for the time while communication with twitter happens, one could do something immediately.

kof avatar Jun 10 '14 12:06 kof

I think in the very least adding a way to change/add via JS will be good. I will look into that (and the config method as well) - thanks!

danwilson avatar Dec 10 '14 00:12 danwilson