oldnyc icon indicating copy to clipboard operation
oldnyc copied to clipboard

Published 20 hours ago • verified publisher icon danvk

about link should not open embedded

Open mgiraldo opened this issue 9 years ago • 5 comments

the behavior of the about link should be like that of a normal link

mgiraldo avatar May 15 '15 20:05 mgiraldo

This was specifically requested at our last meeting—did something change?

danvk avatar May 15 '15 20:05 danvk

what was requested? that it be shown embedded in the map?

i created a pull request with a bunch of changes including this (although doesnt have the JS.... for some reason my JS changes do not work)

mgiraldo avatar May 15 '15 20:05 mgiraldo

maybe you need to comment the bundled.js <script> and uncomment the individual ones in viewer.html?

danvk avatar May 15 '15 20:05 danvk

maybe... i don't know... i am not familiar with the way the site is built... i try to change things so that you dont have to do that but i reach some wall and cant look too much into the cabling

mgiraldo avatar May 15 '15 20:05 mgiraldo

You can also run ./update-js-bundle.sh if you prefer.

On Fri, May 15, 2015 at 4:56 PM Mauricio Giraldo [email protected] wrote:

maybe... i don't know... i am not familiar with the way the site is built... i try to change things so that you dont have to do that but i reach some wall and cant look too much into the cabling

— Reply to this email directly or view it on GitHub https://github.com/danvk/oldnyc/issues/80#issuecomment-102524121.

danvk avatar May 15 '15 20:05 danvk