danvk
Per series roll period
Enables adding of rollPeriod inside series parameters. If rollPeriod is set globally, series will default to that if parameter not set
Coverage increased (+0.01%) to 90.071% when pulling adaa6caa783ef43c254922825ac76d1d607c84b7 on evamedia:per-series-roll-period into 623dd1d6e1562941750eb9f00ac28f2481b07f95 on danvk:master.
Thanks for the contribution! To be considered for merging, this needs unit tests and needs to follow the style of the rest of the dygraphs code.
You can absolutely update per-series options. Here's a demo: http://jsfiddle.net/eM2Mg/9155/
On Thu, Dec 29, 2016 at 4:37 AM, evamedia [email protected] wrote:
Looking into unit tests, can you currently change per-series options with updateOptions() ?
Limited testing seems to say no, I also found this
// TODO(danvk): validate per-series options. // Supported: // strokeWidth // pointSize // drawPoints // highlightCircleSize
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/danvk/dygraphs/pull/811#issuecomment-269604549, or mute the thread https://github.com/notifications/unsubscribe-auth/AAF__fLLt58GIrXcmeCM0181VECUNhIvks5rM39XgaJpZM4LVZD1 .
Coverage increased (+0.09%) to 90.155% when pulling 41047fb504e80b23e787d0e9b69c3613ad503187 on evamedia:per-series-roll-period into 623dd1d6e1562941750eb9f00ac28f2481b07f95 on danvk:master.
apologies, auto_test submitted, can you give me a pointer on the style? Is there a guide?
Coverage increased (+0.09%) to 90.155% when pulling 8c386f1bc20ac5297d769f4b8aa4074fd4a3df3b on evamedia:per-series-roll-period into 623dd1d6e1562941750eb9f00ac28f2481b07f95 on danvk:master.
Coverage increased (+0.1%) to 90.176% when pulling 717ff0b316669a03a802e739f7b17f21c488e2b2 on evamedia:per-series-roll-period into 623dd1d6e1562941750eb9f00ac28f2481b07f95 on danvk:master.
Coverage increased (+0.09%) to 90.148% when pulling c57720f54d663f91b2a12e2c7462b34797bb08e5 on evamedia:per-series-roll-period into 623dd1d6e1562941750eb9f00ac28f2481b07f95 on danvk:master.
Coverage increased (+0.09%) to 90.148% when pulling ab6575d2410e4aec75a060570152edd2820107a2 on evamedia:per-series-roll-period into 623dd1d6e1562941750eb9f00ac28f2481b07f95 on danvk:master.
Coverage increased (+0.1%) to 90.17% when pulling 28c3e15d083fe263f0c109b1af420f9a136b3625 on evamedia:per-series-roll-period into 623dd1d6e1562941750eb9f00ac28f2481b07f95 on danvk:master.
Any idea if/when this functionality gets into the software? Currently I add it manally on each Dygraph release.
