dblab icon indicating copy to clipboard operation
dblab copied to clipboard

[FEATURE] Oracle driver

Open sschneider-ihre-pvs opened this issue 3 years ago • 1 comments

I would like to have support for oracle databases go_ora maybe?

sschneider-ihre-pvs avatar Sep 22 '22 08:09 sschneider-ihre-pvs

Yeah, why not. We recently added support for sqlite. But first, we need to do a massive refactor, to add more drivers, in fact.

danvergara avatar Sep 22 '22 15:09 danvergara

Greate @danvergara when will the release with oracle support be available?

sschneider-ihre-pvs avatar Jun 06 '24 07:06 sschneider-ihre-pvs

@sschneider-ihre-pvs v0.24.0 is already available!!

danvergara avatar Jun 06 '24 14:06 danvergara

great

sschneider-ihre-pvs avatar Jun 06 '24 14:06 sschneider-ihre-pvs

image :( is there a db version restriction?

sschneider-ihre-pvs avatar Jun 06 '24 14:06 sschneider-ihre-pvs

or windows

sschneider-ihre-pvs avatar Jun 06 '24 14:06 sschneider-ihre-pvs

@sschneider-ihre-pvs I think it has to do with the syntax of your query. Is your query using JOINs or ending with semicolons. I got the same error because I wasn't aware of the changes of the Oracle syntax.

danvergara avatar Jun 06 '24 15:06 danvergara

@sschneider-ihre-pvs I think it has to do with the syntax of your query. Is your query using JOINs or ending with semicolons. I got the same error because I wasn't aware of the changes of the Oracle syntax.

I tried to select a table to see the data so ctrl+h navigate to table and hitting enter

sschneider-ihre-pvs avatar Jun 06 '24 16:06 sschneider-ihre-pvs

I tried to select a table to see the data so ctrl+h navigate to table and hitting enter

This is the query I use to fetch the content of the table: Screenshot from 2024-06-06 11-40-22

https://github.com/danvergara/dblab/blob/c7126e786bd224939d418db6e7d26a660e25bd8b/pkg/client/client.go#L336

Can you spot something wrong?

danvergara avatar Jun 06 '24 17:06 danvergara

This is the container image I use for testing:

Screenshot from 2024-06-06 11-43-18

danvergara avatar Jun 06 '24 17:06 danvergara

Ah yes, I have an older db that does not support things like TAKE FETCH NEXT OFFSET and so on, so that would explain it. So I guess you need at least v12c

sschneider-ihre-pvs avatar Jun 07 '24 06:06 sschneider-ihre-pvs