mix_eunit icon indicating copy to clipboard operation
mix_eunit copied to clipboard

Fix output going to wrong directory

Open toland opened this issue 9 years ago • 4 comments

The removed code contained a subtle bug that caused the project output to be placed in '_build/test/test/'. Using preferred_cli_env means that we should always be running in the test env so there is no need to mess around with the build path.

toland avatar Aug 11 '16 02:08 toland

Did you test this with an umbrella project? IIRC that was the main reason I had to jump through those hoops with the build path.

dantswain avatar Aug 20 '16 00:08 dantswain

I have nightmares about umbrella projects 😄

I will test it and make any necessary changes.

toland avatar Aug 23 '16 23:08 toland

See my comment on #7. I think I know how to handle this cleanly, but want to avoid conflicts if possible.

toland avatar Aug 24 '16 20:08 toland

Sorry that it has taken me so long to follow up on this, but I got stuck. I have done some testing with an umbrella project and mix eunit doesn't seem to work with or without this change. I am convinced that the pipeline on lines 92-94 doesn't actually change anything. Pushing the build path back onto the ProjectStack causes the output to go to _build/test/test, but doesn't seem to affect umbrella projects.

There are a couple more things that I want to try, but my day job has got a little busy lately. I will try to look at this again and update the PR in the next few days.

toland avatar Sep 01 '16 23:09 toland