Daniel Townsend

Results 496 comments of Daniel Townsend

That's strange - I wonder if there's some kind of edge case. Do you mind sharing what the column name / type was for your custom primary key, and whether...

OK, interesting - the docs around mixins need expanding upon to cover these details. We just have [this currently](https://piccolo-orm.readthedocs.io/en/latest/piccolo/schema/advanced.html#mixins).

Yeah, it doesn't work at the moment unfortunately. It's not a huge change to Piccolo to make it work, so hopefully we can add it soon.

We just need to change this: https://github.com/piccolo-orm/piccolo/blob/0c44bb22be451e27318ddc2594e7e5a775494f80/piccolo/engine/postgres.py#L393-L397 So instead it's something like: ```python async def batch(self, query: Query, batch_size: int = 100, node: t.Optional[str] = None) -> AsyncBatch: engine =...

@sinisaos No worries - what you suggested made sense.

@sinisaos Do you want to have a go at a PR for this? No pressure - I might be able to do it later today.

Fixed by https://github.com/piccolo-orm/piccolo/pull/579

Yep, this needs adding. A link to a discussion about it: https://github.com/piccolo-orm/piccolo/discussions/175

Reopening, as there are still changes required to Piccolo Admin and Piccolo API.

It's a good idea - the README needs a bit of an overhaul. As you say, to mention more about the wider ecosystem, as it's one of the main selling...