Daniel Friesen

Results 336 comments of Daniel Friesen

@dougwilson Testing the message for the text 'csrf' isn't the proper way to do that. A custom property, name, or custom error type is what I was getting at. However...

Also cannot be used in CRA. This appears to be because the library hardcodes the Webpack specific loading for PDF.js. It doesn't allow you to do this yourself and I'm...

It's a bit more complex but in the meantime my workaround actually is: ```js items = items.splice(0, items.length, ...sortBy(items.slice(), sortFunction)); ``` `.slice()` just the array to a mutable array, sort,...

@arqex I'm talking about the scenario where your array is `[1,2,3]` and so `.sort()` does not change the order of items in the array. `.set` behaves this way, returning the...

Wouldn't this be solved if there were different padding options for favicons, splash screens, and maskable icons? It doesn't really make sense to use the same for all of them.

Actually I think instead of a --masked-padding option I'd prefer being able to use an alternate maskable source. Perhaps we need a --maskable-only/--no-maskable pair of options that would only generate...

Assuming we can't make `--maskable` behave like the `--maskable-only` and pair it with a `--no-maskable`. `--maskable` should probably be deprecated. So the default setting is to only output non-maskable icons,...

Other sites like Reddit use square og:images. https://www.h3xed.com/web-and-internet/how-to-use-og-image-meta-tag-facebook-reddit It may be worth investigating how Facebook, Reddit, and Twitter treat multiple og:image tags with different aspect ratios to see what the...

I just started adding Quill to a project expecting it was the most used/best editor to use. Then I quickly ran into this issue. Now given how long this issue...