simpleeval
simpleeval copied to clipboard
Correctly validate evaluation expression input
- There must be exactly one statement in input
- Given statement must be an expression (assignment, augmented assignment, etc. are not allowed)
Resolves #58 #65 #67
Hello @PPakalns! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
Comment last updated at 2019-12-12 10:30:39 UTC
Coverage increased (+2.6%) to 99.602% when pulling 7ef2214956c7e74309ef2c1d66e24c5857ee7ae2 on PPakalns:master into 66b04c9b8b8fa8ea4daee1b3c02ab0af95e4b8d4 on danthedeckie:master.
Coverage increased (+1.7%) to 98.69% when pulling e3b4ab52df4a0a3135a09ed469a3f5471fa47dd7 on PPakalns:master into 66b04c9b8b8fa8ea4daee1b3c02ab0af95e4b8d4 on danthedeckie:master.
I believe that these issues found by CodeFactor can be fixed in other pull request as I did not introduce them or I used the same style that was already used by this library. If you do not agree I can of course fix these reported errors.
Is this issue dead?
@jeffreyscottgraham There are users that are already dependent on the way how this library is implemented. See this comment and the whole thread.
Looks like 2.0 version of this library needs to be created. If someone needs additional functionality, then new fork of this library, probably, must be created because the activity on this project is very low.
@danthedeckie I recommend closing this PR due to its age.