danthareja
Implement _check
This is the summary of my contribution to the open source project
Basically I did two things. The first was to implement the fuhct _check to avoid repetitions in the code by removing all the redundant codes from different scopes and saving inside a single function. This allowed me to make the code DRY. Next I touch a bit the test file so that the test runs. There were some typos in the test.
And also, I have installed some dependencies in order to run the code on me local machine. I the end three (3) files have been changes:
1 -> calculator.js 2 -> calculator.test.js 3 -> package-lock.json
Yay, a pull request!
After you submit a pull request, one of the following will happen:
:sob: You don’t get a response. :sob:
Even on an active project, it’s possible that your pull request won’t get an immediate response. You should expect some delay as most open source maintainers do so in their free time and can be busy with other tasks.
If you haven’t gotten a response in over a week, it’s fair to politely respond in the same thread, asking someone for a review. If you know the handle of the right person to review your pull request, you can @-mention them to send them a notification. Avoid reaching out to that person privately; remember that public communication is vital to open source projects.
If you make a polite bump and still nobody responds, it’s possible that nobody will respond, ever. It’s not a great feeling, but don’t let that discourage you. It’s happened to everyone! There are many possible reasons why you didn’t get a response, including personal circumstances that may be out of your control. Try to find another project or way to contribute. If anything, this is a good reason not to invest too much time in making a pull request before other community members are engaged and responsive.
:construction: You're asked to make changes to your pull request. :construction:
It’s very common that someone will request changes on your pull request, whether that’s feedback on the scope of your idea, or changes to your code. Often a pull request is just the start of the conversation.
When someone requests changes, be responsive. They’ve taken the time to review your pull request. Opening a PR and walking away is bad form. If you don’t know how to make changes, research the problem, then ask for help if you need it.
If you don’t have time to work on the issue anymore (for example, if the conversation has been going on for months, and your circumstances have changed), let the maintainer know so they’re not expecting a response. Someone else may be happy to take over.
:-1: Your pull request doesn’t get accepted. :-1:
It's possible your pull request may or may not be accepted in the end. If you’re not sure why it wasn’t accepted, it’s perfectly reasonable to ask the maintainer for feedback and clarification. Ultimately, however, you’ll need to respect that this is their decision. Don’t argue or get hostile. You’re always welcome to fork and work on your own version if you disagree!
:tada: Your pull request gets accepted and merged. :tada:
Hooray! You’ve successfully made an open source contribution!
Thank you for the submission, @GANONTHA! I'll review your code shortly, hang tight.
:sparkles: Changes synced :sparkles:
When a pull request is open, GitHub tracks changes to the branch it was opened from. As you push changes to your fork's
masterbranch, you'll automatically see them here.
Thanks for the changes, @GANONTHA. I'm reviewing them now.