stylix icon indicating copy to clipboard operation
stylix copied to clipboard
verified publisher icon danth

gdm: apply icon theme

Open geodic opened this issue 9 months ago • 3 comments

This PR applies the icon theme set by Stylix to GDM.

geodic avatar Mar 08 '25 12:03 geodic

this pr and commit should be titled gdm: apply icon theme per https://stylix.danth.me/commit_convention.html

0xda157 avatar Mar 08 '25 23:03 0xda157

Got it. Let me change them.

geodic avatar Mar 09 '25 11:03 geodic

CI is failing because you need to run the code formatters, see here

danth avatar May 18 '25 12:05 danth

CI passes now :confetti_ball: :confetti_ball:. Good enough to merge?

geodic avatar Jun 08 '25 02:06 geodic

Hi @trueNAHO, I can't really take screenshots on GDM, but this PR basically changes the icons on the panel at the top-right of the screen. Previously this was only done in the GNOME user session, but this PR adds that functionality on the login manager as well.

geodic avatar Aug 17 '25 03:08 geodic

As a non GNOME user I do not exactly know what to look for inside the testbeds.

AFAIK we don't currently have any testbeds where there is an icon theme enabled.

danth avatar Aug 18 '25 18:08 danth

As a non GNOME user I do not exactly know what to look for inside the testbeds.

AFAIK we don't currently have any testbeds where there is an icon theme enabled.

Improving the extent of our testbeds has been briefly discussed in https://github.com/nix-community/stylix/issues/1012. I will try to see how much this situation can be improved.

In the meantime, it might be better to avoid adding a new testbed just for this PR:

https://github.com/nix-community/stylix/blob/82242e0f9b1d91b6f170807a6ec622cfdb816eac/stylix/testbed/themes/README.md#L1-L12

trueNAHO avatar Aug 18 '25 18:08 trueNAHO

Successfully created backport PR for release-25.05:

  • #1849

stylix-automation[bot] avatar Aug 18 '25 19:08 stylix-automation[bot]