stylix icon indicating copy to clipboard operation
stylix copied to clipboard

foot: disable faulty check

Open Mikilio opened this issue 1 year ago • 4 comments

This solves #571. But since this is only a temporary fix, it does not need to be merged. See https://github.com/SenchoPens/base16.nix/issues/15

There may be a way to do this better, but at least it works for me.

Mikilio avatar Sep 26 '24 23:09 Mikilio

This solves #571. But since this is only a temporary fix, it does not need to be merged. See SenchoPens/base16.nix#15

Unless we need to update this input or users override this input with follows, the mentioned issue should not cause any problems.

There may be a way to do this better, but at least it works for me.

It might be easier and better to wait some time for a potential upstream fix. If this becomes a bigger problem and upstream takes too long to fix this, we could apply this temporary hotfix.

trueNAHO avatar Sep 27 '24 07:09 trueNAHO

I agree.

Mikilio avatar Sep 27 '24 11:09 Mikilio

The issue is still there, how to use your pull request as the flake input?

anotherhadi avatar Oct 09 '24 16:10 anotherhadi

The issue is still there, how to use your pull request as the flake input?

You need to change the input to the repo where the pr is coming from (ie github:Mikilio/stylix/temp-fix-foot in this case). Note that the repo is behind some commits compared to master branch here

psynyde avatar Oct 09 '24 16:10 psynyde

Apparently this is still an issue.

Mikilio avatar Nov 04 '24 01:11 Mikilio

So I've changed the fix to simply pinning the tinted-theming/foot repo. Maybe this can actually be merged? If you agree, I will make it ready.

Mikilio avatar Nov 04 '24 02:11 Mikilio

The CI of 6863412636c8f2cb3b7360f747fbd020fbfddf68 is failing for some reason...

trueNAHO avatar Nov 08 '24 18:11 trueNAHO

unpacking 'github:tinted-theming/tinted-foot/fd1b924b6c45c3e4465e8a849e67ea82933fcbe4' into the Git cache...
error:
       … while updating the lock file of flake 'github:danth/stylix/655528278fd89fd7f3149f47fdca994b08dd0b71?narHash=sha256-Jg7peqzVbv4ULKNyx9wVIevsLbycDWfSfGpqheX06dc%3D'

       error: cannot write modified lock file of flake 'github:danth/stylix/655528278fd89fd7f3149f47fdca994b08dd0b71' (use '--no-write-lock-file' to ignore)

Well, I did not update the lockfile. That much is true. So maybe it should be updated for the CI? A simple nix flake lock --update-input tinted-foot should suffice (did not check for typos).

Mikilio avatar Nov 09 '24 07:11 Mikilio