dunst: set icon theme

[huuff]

Description

I've noticed the dunst target doesn't try to set an icon theme, even though the home manager module for dunst offers a direct configuration option for the icon theme.

I haven't found any previous issues on the topic. Has this been tried before, and have there been any challenges? I could try to make a PR if this is desirable.

Submission Checklist

• [x] I assert that this issue is relevant to Stylix
• [x] I assert that this is not a duplicate of an existing issue

Notify maintainers

No response

[trueNAHO]

I've noticed the dunst target doesn't try to set an icon theme, even though the home manager module for dunst offers a direct configuration option for the icon theme.

I haven't found any previous issues on the topic. Has this been tried before, and have there been any challenges? I could try to make a PR if this is desirable.

Does https://github.com/nix-community/stylix/pull/1941 resolve this?

[huuff]

🤔 I don't fully understand what copyModules does there, I doubt it would resolve the issue. Since stylix doesn't attempt to set the icon theme, and the home manager module for dunst uses the hicolor one as a default, it will always be picked regarding of what stylix does.

[trueNAHO]

I don't fully understand what copyModules does there, I doubt it would resolve the issue. Since stylix doesn't attempt to set the icon theme, and the home manager module for dunst uses the hicolor one as a default, it will always be picked regarding of what stylix does.

My bad. I misunderstood your question and did not double check the implementation.

I've noticed the dunst target doesn't try to set an icon theme, even though the home manager module for dunst offers a direct configuration option for the icon theme.

Somehow I misunderstood that our module declares the icon theme without any visual effect. Your question was why we have not declared the icon theme yet.

Has this been tried before, and have there been any challenges?

IIRC, this has not been tried before. Likely, Home Manager's icon theme option did not yet exist at the time of commit 0fb9f236a30a ("Add Dunst module") from almost 6 years ago.

I could try to make a PR if this is desirable.

Yes, feel free to open a PR. Improving module functionality is highly appreciated.

Also, consider adding yourself as a module maintainer to the dunst module.

[danth]

Likely, Home Manager's icon theme option did not yet exist at the time of commit 0fb9f23 ("Add Dunst module") from almost 6 years ago.

I'm fairly sure Stylix didn't have icon theme support at that time either, so even if an upstream option existed we wouldn't have used it. I don't personally use Dunst any more so I haven't got round to updating the module.