Daniel Thwaites

Results 350 comments of Daniel Thwaites

> should we expose the NixVim config through `config.lib.stylix.nixvim.config`? As mentioned, this is consistent with what we are currently doing in other modules, so it's fine by me. (Eventually, we...

> In the future, this could be improved by providing a read-only option I agree, read-only options under `stylix.targets.«name»` are the best way to handle things like this.

Could it somehow be referencing an automatically generated color scheme when you use `${colors}`? Since that would depend on the final image.

That condition exists so that if you explicitly set a wallpaper in Home Manager, and it's different to the wallpaper used in NixOS, then it won't copy the color scheme...

I'm reluctant to merge this because, as previously discussed, it goes beyond Stylix's goal of "take these theming items, and apply them everywhere". If we were to instead provide the...

The original idea of Stylix was "give it an image, and everything else happens automatically" hence the palette generator exists, but I think we've strayed from that by adding more...

> Unless `generatePalette` becomes unbearably slow, the `base16`, `base24` and `highlight` schemes should be directly generated from the image to avoid any form of precision loss. This could be problematic...

> considering that this PR will be replaced in the future anyway @trueNAHO Could you clarify what you meant by this? (Sorry, I've lost track of the conversation since it's...

Is this a GTK application? If not, we will need to write a specific module to theme it. If it is, it may be overriding the system theme with its...

I'm not familiar with the details of Flatpak, but if you can somehow make `~/.config/gtk-3.0` and `~/.config/gtk-4.0` visible to the app then it should pick up the theme.