Daniel Thwaites

Results 350 comments of Daniel Thwaites

Since waybar is often heavily customised, it's hard to provide a module which isn't opinionated. Right now the module assumes that the styles won't be changed much by the user,...

After the changes in #398 and #399, would it make more sense to do the following? 1. For modules which pass something other than a constant `true` or `false` to...

> Do you mean replacing No, I mean cases where the argument to `mkEnableTarget` takes the value of some other option, for example https://github.com/danth/stylix/blob/99bcaa552096ccff21658a9eb6a1e8397b10eb78/modules/gnome/nixos.nix#L8-L10 rather than a simple `true` or...

> To keep the functionality of enabling or disabling all Stylix styling, it seems like a `autoEnable` option is good after all. Maybe we should rename it to something more...

So, I've found a couple of problems which still need to be fixed: ## Issue 1 When `stylix.enable` is `false`, you can still enable a target by explicitly setting `stylix.targets.«name».enable`...

I managed to do the first part with some `sed` magic, just need to go through and fix the second issue by hand now.

> Can `docs/settings.nix` be removed due to the new `stylix.enable` option? Not yet: although the option is not required any more, the default value for `stylix.image` is still of an...

Yep, I had already set that for auto-merge, just using ` rather than '

Apologies, I meant `selection` (which is still `base03`), not `background`. `base00` is correct as a general background color.

In that case, I think it's fine. We don't really have an agreed color for selection foregrounds right now.