gmphd icon indicating copy to clipboard operation
gmphd copied to clipboard

Variable 'pkk' line #163 gmphd.py is not used

Open JohnPekl opened this issue 4 years ago • 2 comments

Your code did not use pkk though you calculated.

pkk = [dot(eye(len(k[index])) - dot(k[index], self.h), comp.cov)

JohnPekl avatar Jan 12 '21 03:01 JohnPekl

According to Table I, I think your code should change in this line #180 in gmphd.py from comp.cov to pkk[j].

image

JohnPekl avatar Jan 20 '21 15:01 JohnPekl

Thank you - I agree with you, that looks like an error in the implementation. Thanks for finding it!

Replacing comp.cov with pkk[j] gives me a "singular matrix error" when I run my synthetic example. I may need to dig through and remember this old code, to work out how to fix this.

danstowell avatar Jan 23 '21 17:01 danstowell