Prism.Plugin.Popups icon indicating copy to clipboard operation
Prism.Plugin.Popups copied to clipboard

GoBackAsync does not trigger OnNavigateTo if using FlyoutPage

Open davibittencourtome opened this issue 3 years ago • 11 comments

No projeto de amostra, ao navegar a partir do exemplo "FLYOUT PAGE", o GoBackAsync não dispara o OnNavigatedTo da viewModel MainPageViewModel:

https://github.com/dansiegel/Prism.Plugin.Popups/blob/b35e05473e23493b75cdd2ab617fde0300d84ce3/samples/src/PopupPluginSample/ViewModels/PopupViewModel.cs#L52

private async void OnNavigateBackCommandExecuted() { await _navigationService.GoBackAsync(new NavigationParameters{ { "message", "Hello from the Popup View" } }); }

I noticed that when navigating from the example "MASTER DETAIL PAGE" it works normally.

What could it be ? should i configure something specific or would it be a navigation issue with FlyoutPage ?

davibittencourtome avatar Sep 15 '21 00:09 davibittencourtome

Prism 8.0 does NOT support FlyoutPage

dansiegel avatar Sep 15 '21 01:09 dansiegel

We use Prism 8.1 and FlyoutPage is supported by this version. Corresponding Pull request

Is the problem that FlyoutPage should also be added at this code position? Prism.Plugin.Popups.Extensions.PageExtensions

Andreas0xffff avatar Sep 15 '21 13:09 Andreas0xffff

Exactly @Andreas0xffff , we are using version 8.1.97. We will have to wait for an update with this fix.

davibittencourtome avatar Sep 15 '21 13:09 davibittencourtome

@davibittencourtome Wait for an update of PrismLibrary/Prism (current version 8.1.97) or dansiegel/Prism.Plugin.Popups (current version 8.0.76)? The Prism.Plugin.Popups alredy references 8.1.97 in its csproj. I think this issue should be reopened.

Andreas0xffff avatar Sep 15 '21 15:09 Andreas0xffff

@dansiegel Any news on this?

Andreas0xffff avatar Sep 21 '21 13:09 Andreas0xffff

I'm working around with EventAggregator to get around the problem, until a new corrected version comes out

davibittencourtome avatar Sep 21 '21 13:09 davibittencourtome

same issue, reverting to MasterDetailPage works.

itoledo avatar Sep 22 '21 22:09 itoledo

This is an open source repo, and I do take PRs. However keep in mind that I am busy with several different libraries and am unlikely to get to this in the next month.

dansiegel avatar Sep 22 '21 23:09 dansiegel

Any updates on this?

markrobert194 avatar Feb 18 '22 14:02 markrobert194

This problem is already solved in the master branch. So we need to do one of the following:

  • Become a sponsor, so we get access to the nuget feed with the pre-release
  • Build and add the nuget package to a private feed ourselves
  • Be patient

JaccoDieleman avatar Mar 11 '22 14:03 JaccoDieleman

I'd add to your list:

dansiegel avatar Mar 11 '22 15:03 dansiegel