predicates

predicates copied to clipboard

stack-buffer-overflow in fast_expansion_sum_zeroelim

3

I found this issue in the original predicates code, and can reproduce it also in your code (or in my fork of your repo): https://travis-ci.com/github/dyollb/predicates/jobs/353312903 1: ==5947==ERROR: AddressSanitizer: stack-buffer-overflow on...

dyollb

Inconsistency with `incircle`

2

I have found what looks like inconsistencies with the predicate `incircle`. You will find in dca6f4c2c75086e6e56ecd343e53d7b8e7221b1d a new unit test that shows the supposed bug. I construct 4 collinear points...

lairez

fwiw there is a version of the predicates code that Shewchuk did release under BSD; it's buried in Starbase.c inside Stellar, here: https://people.eecs.berkeley.edu/~jrs/stellar/ Also, I think anything you added on...

jimmyland

Invalid incircle unit test

2

The [incircle unit test](https://github.com/danshapero/predicates/blob/51f25ab0e9791ea21c16816ce80114236a5d68b3/test/incircle.cpp#L55) is invalid. There is a roundoff in `r2` calculation, so `r2` is always equals to `n*n` despite the perturbation of `q`. ``` const double y[] =...

kireevtf