Daniel Carpenter

icon location A Berlin based developer. Studied Physics for a while, has since moved to the web and isn't looking back. A huge fan of Python, Django and Vue.

Results 16 comments of Daniel Carpenter

#12473 Support endpoints provided by plugins in strports.listen

I'm not writing a test if the function may become deprecated, and I'm not deprecating it myself. If you do not accept the PR as-is, please close it.

`adoptStreamPort` should not try to chmod unix sockets.

I just stumbled across this problem. [This is the offending chmod](https://github.com/twisted/twisted/blob/edd9a8abeb95420c1299c4923e40e3ef196e1556/src/twisted/internet/unix.py#L431). The comment above it is alarming - "Make the socket readable and writable to the world.". I already made...

`adoptStreamPort` should not try to chmod unix sockets.

Also, the [docs are outdated](https://docs.twisted.org/en/stable/core/howto/systemd.html). > but Twisted currently only accepts IPv4 and IPv6 TCP sockets. It also accepts unix sockets.

#10261 Do not chmod preexisting UNIX socket

please review. I'm not sure how there can be performance regressions - the change just adds one simple check. Does it need an automated test?

#10261 Do not chmod preexisting UNIX socket

Thank you both for the kind, swift and thoughtful feedback. It's maybe inconsistent - `unix.Port` and `listenUNIX` now have `mode = None`, but `UNIXServerEndpoint` still has `mode = 0o666`. Is...

#10261 Do not chmod preexisting UNIX socket

OK. I changed all those. I now see there is a similar problem: `unix.port.connectionLost` calls `os.unlink(self.port)` which also fails in this case. Considering that, I'm leaning back to the original...